Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report suggestions to repository #3110

Closed
wants to merge 12 commits into from

Conversation

SahilDhillon21
Copy link
Contributor

Fixes #3104

Needs work and testing

@SahilDhillon21 SahilDhillon21 marked this pull request as ready for review December 22, 2024 12:56
@SahilDhillon21
Copy link
Contributor Author

Do you have any suggestions on how this test can be resolved?

Verified

This commit was signed with the committer’s verified signature.
@SahilDhillon21
Copy link
Contributor Author

All conflicts are resolved, please verify

@DonnieBLT DonnieBLT enabled auto-merge (squash) January 19, 2025 00:52

Verified

This commit was signed with the committer’s verified signature.
DonnieBLT
DonnieBLT previously approved these changes Jan 26, 2025
@DonnieBLT
Copy link
Collaborator

Ptal

Verified

This commit was signed with the committer’s verified signature.
auto-merge was automatically disabled January 26, 2025 19:30

Head branch was pushed to by a user without write access

SahilDhillon21 and others added 3 commits January 30, 2025 15:28
@SahilDhillon21
Copy link
Contributor Author

Demonstration on sample repository:

suggestion-trial.mp4

Updated the GITHUB_URL in settings to the proper URL and added some extra env variables for convenience in the future
Please let me know if we want to keep the env variables and settings the same

SahilDhillon21 and others added 6 commits February 1, 2025 21:49
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to allow the user to enter other repo urls and not have all the suggestions to into our repo. not sure if this feature would be used much, maybe we can skip this one.

@DonnieBLT
Copy link
Collaborator

we turned the suggestion feature into a forum so this may not apply anymore, you still get credit for this PR though, thank you.

@DonnieBLT DonnieBLT closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestions could be linked to github repo just like issues
2 participants