Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix presentation issues with CCM-8 notes #2408

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

randomstuff
Copy link
Contributor

No description provided.

@tghosth tghosth marked this pull request as draft November 25, 2024 09:15
@tghosth
Copy link
Collaborator

tghosth commented Nov 25, 2024

Pretty sure those asterisks are there deliberately to reference notes below, do they need escaping?

@randomstuff
Copy link
Contributor Author

Yes, either these should be removed or these should be fixed:

  • escaping the leading "*" so that it is not seen as a list item
  • "CCM-8**" →"CCM-8*"

@tghosth
Copy link
Collaborator

tghosth commented Nov 25, 2024

You wanna try and fix?

@randomstuff
Copy link
Contributor Author

Done.

@tghosth
Copy link
Collaborator

tghosth commented Dec 2, 2024

Hi @danielcuthbert please could you review this

Copy link
Collaborator

@danielcuthbert danielcuthbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tghosth tghosth marked this pull request as ready for review December 7, 2024 19:30
@tghosth tghosth merged commit c57946e into OWASP:master Dec 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants