-
-
Notifications
You must be signed in to change notification settings - Fork 102
Revamp About Page: Thematic Section Enhancements, Dynamic Content Structuring, and Comprehensive Testing Integration #1584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rishyym0927
wants to merge
23
commits into
OWASP:main
Choose a base branch
from
rishyym0927:about
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
52528c0
Fix about page
rishyym0927 acc8609
Tests fix
rishyym0927 6681ba7
test fix
rishyym0927 d74913e
Test fix and optimization
rishyym0927 065e202
Merge branch 'main' into about
kasya 881fe41
Merge branch 'OWASP:main' into about
rishyym0927 af99246
Test fix and splitting
rishyym0927 74e9f3c
Test fix
rishyym0927 76d67b6
Merge branch 'main' into about
rishyym0927 b261546
Keys Fix
rishyym0927 bf8efd0
Merge branch 'main' into about
rishyym0927 3324527
Test for new sections
rishyym0927 4f3184b
Fix
rishyym0927 547a7c4
Update frontend/src/app/about/page.tsx
rishyym0927 3cfda2f
Merge branch 'main' into about
kasya 21650ec
Merge branch 'main' into about
rishyym0927 9c3ba89
Fix
rishyym0927 bffec13
Fixed
rishyym0927 f5c1bda
Merge branch 'main' into about
rishyym0927 b78ab0f
Fix1
rishyym0927 f8c858b
Fix2
rishyym0927 af2374d
Merge branch 'main' into about
kasya 2e6ba87
Merge branch 'main' into about
kasya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,78 @@ jest.mock('utils/aboutData', () => ({ | |
'This is a test paragraph about the project.', | ||
'This is another paragraph about the project history.', | ||
], | ||
leaders: { | ||
arkid15r: 'CCSP, CISSP, CSSLP', | ||
kasya: 'CC', | ||
mamicidal: 'CISSP', | ||
}, | ||
missionContent: { | ||
mission: | ||
'OWASP Nest is a comprehensive platform designed to empower developers, security professionals, and organizations in their journey toward building secure applications.', | ||
whoItsFor: | ||
'OWASP Nest is designed for developers, security professionals, project leaders, and organizations looking to integrate security best practices into their development workflows.', | ||
}, | ||
keyFeatures: [ | ||
{ | ||
title: 'Advanced Search Capabilities', | ||
description: | ||
'Find OWASP projects, tools, and resources with precision using our intelligent search functionality.', | ||
}, | ||
{ | ||
title: 'Slack Integration', | ||
description: 'Stay connected with the OWASP community through seamless Slack integration.', | ||
}, | ||
{ | ||
title: 'OWASP Chapters Proximity Page', | ||
description: | ||
'Discover local OWASP chapters and events near you to engage with the community.', | ||
}, | ||
{ | ||
title: 'AI-Generated Insights', | ||
description: | ||
'Leverage AI-powered insights to better understand project relationships and recommendations.', | ||
}, | ||
], | ||
getInvolvedContent: { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
description: | ||
'OWASP Nest thrives thanks to community-driven contributions. Here are ways you can get involved:', | ||
ways: [ | ||
'Code Contributions β Fix bugs or build new features.', | ||
'Code Review β Improve quality by reviewing pull requests.', | ||
'Documentation β Help improve our guides and tutorials.', | ||
'Testing β Report bugs and help test new features.', | ||
'Community Engagement β Share your experiences and help others.', | ||
], | ||
callToAction: | ||
'To get started, visit the OWASP Nest Repository, explore the Contributing Guidelines, and review the Code of Conduct.', | ||
}, | ||
projectHistory: [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
{ | ||
year: '2023', | ||
title: 'Project Inception', | ||
description: 'The project was started and initial planning began.', | ||
}, | ||
{ | ||
year: '2023', | ||
title: 'Backend MVP', | ||
description: 'The backend MVP was released.', | ||
}, | ||
{ | ||
year: '2024', | ||
title: 'Frontend Development', | ||
description: 'Frontend development kicked off.', | ||
}, | ||
{ | ||
year: '2024', | ||
title: 'Platform Integrations', | ||
description: 'Integrated with several platforms.', | ||
}, | ||
{ | ||
year: '2024', | ||
title: 'GSoC Integration', | ||
description: 'Google Summer of Code integration completed.', | ||
}, | ||
], | ||
technologies: [ | ||
{ | ||
section: 'Backend', | ||
|
@@ -43,6 +115,14 @@ jest.mock('utils/aboutData', () => ({ | |
icon: '/images/icons/python.svg', | ||
url: 'https://www.python.org/', | ||
}, | ||
Django: { | ||
icon: '/images/icons/django.svg', | ||
url: 'https://www.djangoproject.com/', | ||
}, | ||
PostgreSQL: { | ||
icon: '/images/icons/postgresql.svg', | ||
url: 'https://www.postgresql.org/', | ||
}, | ||
}, | ||
}, | ||
{ | ||
|
@@ -52,6 +132,14 @@ jest.mock('utils/aboutData', () => ({ | |
icon: '/images/icons/nextjs.svg', | ||
url: 'https://nextjs.org/', | ||
}, | ||
'Tailwind CSS': { | ||
icon: '/images/icons/tailwind.svg', | ||
url: 'https://tailwindcss.com/', | ||
}, | ||
Typescript: { | ||
icon: '/images/icons/typescript.svg', | ||
url: 'https://www.typescriptlang.org/', | ||
}, | ||
}, | ||
}, | ||
{ | ||
|
@@ -65,6 +153,10 @@ jest.mock('utils/aboutData', () => ({ | |
icon: '/images/icons/pytest.svg', | ||
url: 'https://docs.pytest.org/', | ||
}, | ||
PlayWright: { | ||
icon: '/images/icons/playwright.svg', | ||
url: 'https://playwright.dev/', | ||
}, | ||
}, | ||
}, | ||
{ | ||
|
@@ -74,6 +166,10 @@ jest.mock('utils/aboutData', () => ({ | |
icon: '/images/icons/ansible.svg', | ||
url: 'https://www.ansible.com/', | ||
}, | ||
Docker: { | ||
icon: '/images/icons/docker.svg', | ||
url: 'https://www.docker.com/', | ||
}, | ||
GitHub: { | ||
icon: '/images/icons/github.svg', | ||
url: 'https://www.github.com/', | ||
|
@@ -138,20 +234,70 @@ describe('About Component', () => { | |
jest.clearAllMocks() | ||
}) | ||
|
||
test('renders project history correctly', async () => { | ||
test('renders mission and who its for sections correctly', async () => { | ||
await act(async () => { | ||
render(<About />) | ||
}) | ||
|
||
const missionSection = screen.getByText('Mission').closest('div') | ||
expect(missionSection).toBeInTheDocument() | ||
expect(screen.getByText(/OWASP Nest is a comprehensive platform/)).toBeInTheDocument() | ||
|
||
const whoItsForSection = screen.getByText("Who It's For").closest('div') | ||
expect(whoItsForSection).toBeInTheDocument() | ||
expect(screen.getByText(/OWASP Nest is designed for developers/)).toBeInTheDocument() | ||
}) | ||
|
||
test('renders key features section correctly', async () => { | ||
await act(async () => { | ||
render(<About />) | ||
}) | ||
|
||
const historySection = screen.getByText('History').closest('div') | ||
expect(historySection).toBeInTheDocument() | ||
const keyFeaturesSection = screen.getByText('Key Features').closest('div') | ||
expect(keyFeaturesSection).toBeInTheDocument() | ||
|
||
const markdownContents = await screen.findAllByTestId('markdown-content') | ||
expect(markdownContents.length).toBe(2) | ||
expect(markdownContents[0].textContent).toBe('This is a test paragraph about the project.') | ||
expect(markdownContents[1].textContent).toBe( | ||
'This is another paragraph about the project history.' | ||
) | ||
expect(screen.getByText('Advanced Search Capabilities')).toBeInTheDocument() | ||
expect(screen.getByText('Slack Integration')).toBeInTheDocument() | ||
expect(screen.getByText('OWASP Chapters Proximity Page')).toBeInTheDocument() | ||
expect(screen.getByText('AI-Generated Insights')).toBeInTheDocument() | ||
}) | ||
|
||
test('renders get involved section correctly', async () => { | ||
await act(async () => { | ||
render(<About />) | ||
}) | ||
|
||
const getInvolvedSection = screen.getByText('Get Involved').closest('div') | ||
expect(getInvolvedSection).toBeInTheDocument() | ||
|
||
expect( | ||
screen.getByText(/OWASP Nest thrives thanks to community-driven contributions/) | ||
).toBeInTheDocument() | ||
expect( | ||
screen.getByText(/Code Contributions β Fix bugs or build new features/) | ||
).toBeInTheDocument() | ||
expect( | ||
screen.getByText(/Code Review β Improve quality by reviewing pull requests/) | ||
).toBeInTheDocument() | ||
}) | ||
|
||
test('renders project history timeline correctly', async () => { | ||
await act(async () => { | ||
render(<About />) | ||
}) | ||
|
||
const projectHistorySection = screen.getByText('Project History').closest('div') | ||
expect(projectHistorySection).toBeInTheDocument() | ||
|
||
expect(screen.getByText('Project Inception')).toBeInTheDocument() | ||
expect(screen.getByText('Backend MVP')).toBeInTheDocument() | ||
expect(screen.getByText('Frontend Development')).toBeInTheDocument() | ||
expect(screen.getByText('Platform Integrations')).toBeInTheDocument() | ||
expect(screen.getByText('GSoC Integration')).toBeInTheDocument() | ||
|
||
// Check for year indicators | ||
expect(screen.getAllByText('23')).toHaveLength(2) // 2023 entries | ||
expect(screen.getAllByText('24')).toHaveLength(3) // 2024 entries | ||
}) | ||
|
||
test('renders leaders section with three leaders', async () => { | ||
|
@@ -576,4 +722,58 @@ describe('About Component', () => { | |
}) | ||
}) | ||
}) | ||
|
||
test('renders mission section', async () => { | ||
await act(async () => { | ||
render(<About />) | ||
}) | ||
expect(screen.getByText('Mission')).toBeInTheDocument() | ||
expect(screen.getByText(/empower developers, security professionals/)).toBeInTheDocument() | ||
}) | ||
|
||
test("renders 'Who It's For' section", async () => { | ||
await act(async () => { | ||
render(<About />) | ||
}) | ||
expect(screen.getByText("Who It's For")).toBeInTheDocument() | ||
expect( | ||
screen.getByText(/developers, security professionals, project leaders/) | ||
).toBeInTheDocument() | ||
}) | ||
|
||
test('renders key features section', async () => { | ||
await act(async () => { | ||
render(<About />) | ||
}) | ||
expect(screen.getByText('Key Features')).toBeInTheDocument() | ||
expect(screen.getByText('Advanced Search Capabilities')).toBeInTheDocument() | ||
expect(screen.getByText('Slack Integration')).toBeInTheDocument() | ||
expect(screen.getByText('OWASP Chapters Proximity Page')).toBeInTheDocument() | ||
expect(screen.getByText('AI-Generated Insights')).toBeInTheDocument() | ||
}) | ||
|
||
test('renders get involved section', async () => { | ||
await act(async () => { | ||
render(<About />) | ||
}) | ||
expect(screen.getByText('Get Involved')).toBeInTheDocument() | ||
expect(screen.getByText(/community-driven contributions/)).toBeInTheDocument() | ||
expect(screen.getByText(/Code Contributions/)).toBeInTheDocument() | ||
expect(screen.getByText(/Code Review/)).toBeInTheDocument() | ||
expect(screen.getByText(/Documentation/)).toBeInTheDocument() | ||
expect(screen.getByText(/Testing/)).toBeInTheDocument() | ||
expect(screen.getByText(/Community Engagement/)).toBeInTheDocument() | ||
}) | ||
|
||
test('renders project history timeline section', async () => { | ||
await act(async () => { | ||
render(<About />) | ||
}) | ||
expect(screen.getByText('Project History')).toBeInTheDocument() | ||
expect(screen.getByText('Project Inception')).toBeInTheDocument() | ||
expect(screen.getByText('Backend MVP')).toBeInTheDocument() | ||
expect(screen.getByText('Frontend Development')).toBeInTheDocument() | ||
expect(screen.getByText('Platform Integrations')).toBeInTheDocument() | ||
expect(screen.getByText('GSoC Integration')).toBeInTheDocument() | ||
}) | ||
}) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look like exact copies of what we have in
aboutData.ts
. Can we avoid the duplication?