-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enforced lint to avoid console.* in prod #187
Conversation
@arkid15r please help review these changes . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @yashpandey06
Let's discuss some topics below:
c3a7b5b
to
3282317
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the eslint rule for actual no-console
enforcement.
c33f6ce
to
764fba9
Compare
764fba9
to
f4eb9b9
Compare
29a2593
to
1176338
Compare
73e26a9
to
32a1bc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks better but I haven't tested it. Please address the recently added comments and let's merge it. I think it's good enough to be merged and improved incrementally.
Thanks for adding this!
3b8fc7b
to
06daf60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge and start using it
Fixes #186
This PR enforces linting rules to disallow the use of
console.*
statements in the project. These changes include adding a lint rule to the CI/CD pipeline and updating thepackage.json
to ensure that the rule is checked and enforced during the development and deployment process.Summary of Changes
CI/CD Pipeline:
npm run lint
as part of the pipeline, ensuring that theconsole.*
lint rule is enforced in every push/merge request.package.json:
eslint
configuration is applied to disallowconsole.*
statements during linting.lint:check
script to check for anyconsole.*
usage and fail the build if any are found.