Skip to content

fix(ui): improve mobile navigation menu in Header.tsx #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 6, 2025
Merged

fix(ui): improve mobile navigation menu in Header.tsx #2217

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf9a623
fix(ui): fixed usermenu styling on mobile screens
ishanBahuguna Sep 5, 2025
dca4e7e
fixed syntax issue
ishanBahuguna Sep 5, 2025
ae62ac8
Merge branch 'main' into feature/improve-user-navigation-menu-on-smal…
ishanBahuguna Sep 5, 2025
1ed027c
Update styling
kasya Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions frontend/src/components/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,11 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
<div className="md:hidden">
<Button
onPress={toggleMobileMenu}
className="bg-transparent text-slate-300 hover:bg-transparent hover:text-slate-100 focus:outline-hidden"
className="flex h-11 w-11 items-center justify-center bg-transparent text-slate-300 hover:bg-transparent hover:text-slate-100 focus:outline-hidden"
>
<span className="sr-only">Open main menu</span>
{mobileMenuOpen ? (
<FontAwesomeIcon icon={faTimes} className="h-6 w-6" />
<FontAwesomeIcon icon={faTimes} size="2x" />
) : (
<FontAwesomeIcon icon={faBars} className="h-6 w-6" />
)}
Expand All @@ -153,7 +153,7 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
>
<div className="flex h-full flex-col justify-between gap-1 px-2 pt-2 pb-3">
{/* Logo */}
<div className="flex flex-col justify-center gap-1">
<div className="flex flex-col justify-center gap-5">
<Link href="/" onClick={() => setMobileMenuOpen(false)}>
<div className="flex h-full items-center">
<Image
Expand Down Expand Up @@ -186,8 +186,8 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
})
.map((link) =>
link.submenu ? (
<div key={link.text} className="flex flex-col">
<div className="block px-3 py-2 font-medium text-slate-700 dark:text-slate-300">
<div key={link.text} className="flex flex-col gap-2">
<div className="block px-3 py-3 font-medium text-slate-700 dark:text-slate-300">
{link.text}
</div>
<div className="ml-4">
Expand All @@ -196,7 +196,7 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
key={i}
href={sub.href || '/'}
className={cn(
'block w-full px-4 py-2 text-left text-sm text-slate-700 transition duration-150 ease-in-out first:rounded-t-md last:rounded-b-md hover:bg-slate-100 hover:text-slate-900 dark:text-slate-300 dark:hover:bg-slate-700 dark:hover:text-white',
'block w-full px-4 py-3 text-left text-sm text-slate-700 transition duration-150 ease-in-out first:rounded-t-md last:rounded-b-md hover:bg-slate-100 hover:text-slate-900 dark:text-slate-300 dark:hover:bg-slate-700 dark:hover:text-white',
pathname === sub.href &&
'bg-blue-50 font-medium text-blue-600 dark:bg-blue-900/20 dark:text-blue-200'
)}
Expand All @@ -212,7 +212,7 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
key={link.text}
href={link.href || '/'}
className={cn(
'navlink block px-3 py-2 text-slate-700 hover:text-slate-800 dark:text-slate-300 dark:hover:text-slate-200',
'navlink block px-3 py-2 text-slate-700 transition duration-150 ease-in-out hover:bg-slate-100 hover:text-slate-900 dark:text-slate-300 dark:hover:bg-slate-700 dark:hover:text-white',
pathname === link.href && 'font-bold text-blue-800 dark:text-white'
)}
onClick={toggleMobileMenu}
Expand Down