Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Test Coverage for github/models #328

Merged
merged 13 commits into from
Jan 16, 2025
Merged

Improve Test Coverage for github/models #328

merged 13 commits into from
Jan 16, 2025

Conversation

yashpandey06
Copy link
Collaborator

Screenshot 2025-01-02 022755

@yashpandey06 yashpandey06 requested a review from arkid15r as a code owner January 1, 2025 21:06
@yashpandey06 yashpandey06 marked this pull request as draft January 1, 2025 21:08
@yashpandey06 yashpandey06 marked this pull request as ready for review January 1, 2025 21:34
@arkid15r arkid15r linked an issue Jan 2, 2025 that may be closed by this pull request
Increase backend github/models coverage #282
Closed
arkid15r
arkid15r requested changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this @yashpandey06
Please address the comments below when you get a chance:

backend/tests/github/models/issue_tests.py Outdated Show resolved Hide resolved
backend/tests/github/models/issue_tests.py Outdated Show resolved Hide resolved
backend/tests/github/models/issue_tests.py Outdated Show resolved Hide resolved
backend/tests/github/models/issue_tests.py Outdated Show resolved Hide resolved
backend/tests/github/models/issue_tests.py Outdated Show resolved Hide resolved
backend/tests/github/models/repository_tests.py Outdated Show resolved Hide resolved
backend/tests/github/models/repository_tests.py Show resolved Hide resolved
backend/tests/github/models/user_tests.py Outdated Show resolved Hide resolved
backend/tests/github/models/user_tests.py Outdated Show resolved Hide resolved
backend/tests/github/utils_tests.py Outdated Show resolved Hide resolved
@yashpandey06 yashpandey06 force-pushed the Nest-issue-282 branch 3 times, most recently from d89c98b to c413bd3 Compare January 3, 2025 08:15
@yashpandey06 yashpandey06 requested a review from arkid15r January 3, 2025 08:23
arkid15r
arkid15r requested changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address all comment and leave actual marking comments as resolved to reviewers.

backend/tests/github/models/mixins/mixins_issue_tests.py Outdated Show resolved Hide resolved
backend/tests/github/models/mixins/mixins_issue_tests.py Outdated Show resolved Hide resolved
backend/tests/github/models/repository_tests.py Outdated Show resolved Hide resolved
backend/tests/github/models/user_tests.py Show resolved Hide resolved
backend/tests/github/models/user_tests.py Outdated Show resolved Hide resolved
@yashpandey06 yashpandey06 requested a review from arkid15r January 4, 2025 01:01
@yashpandey06 yashpandey06 requested a review from arkid15r January 4, 2025 22:25
@yashpandey06 yashpandey06 force-pushed the Nest-issue-282 branch 9 times, most recently from cf369bf to 92f0eba Compare January 7, 2025 09:55
@arkid15r arkid15r marked this pull request as draft January 13, 2025 04:58
arkid15r
arkid15r reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you still want to complete this. I'm going to re-assign it has been open for a while with no end result.

This is a blocker to 75% coverage enforcement.
Required test coverage of 50% reached. Total coverage: 74.66%

@yashpandey06
Copy link
Collaborator Author

@arkid15r will push the latest changes today ...was busy with the other work ..Apologies for late intimation

@yashpandey06 yashpandey06 force-pushed the Nest-issue-282 branch 4 times, most recently from fc279ea to 377fcf5 Compare January 13, 2025 10:19
@yashpandey06 yashpandey06 marked this pull request as ready for review January 14, 2025 16:07
@yashpandey06 yashpandey06 requested a review from arkid15r January 14, 2025 16:08
arkid15r
arkid15r approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this,
thank you @yashpandey06

@arkid15r arkid15r enabled auto-merge January 16, 2025 23:03
@arkid15r arkid15r added this pull request to the merge queue Jan 16, 2025
Merged via the queue into OWASP:main with commit 5cdf76f Jan 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r approved these changes

Assignees
No one assigned
Labels
backend backend-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase backend github/models coverage
2 participants
@yashpandey06 @arkid15r