Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement User Details Page #349

Merged
merged 8 commits into from
Jan 8, 2025
Merged

Implement User Details Page #349

merged 8 commits into from
Jan 8, 2025

Conversation

harsh3dev
Copy link
Collaborator

@harsh3dev harsh3dev commented Jan 6, 2025 •
edited
Loading

Resolves #291

  • Update the user API to send more details
  • use the details to showcase a custom user profile (Responsive)
  • update the ContributorAvatar component to redirect to the new user details page
  • The page is accessible at: /user/:login
  • Add Tests for the component

Dark Theme:

image

Light Theme:

image

@harsh3dev harsh3dev marked this pull request as draft January 6, 2025 11:53
@harsh3dev harsh3dev marked this pull request as ready for review January 6, 2025 13:59
arkid15r
arkid15r requested changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI looks good, we need to change the data source though:

frontend/src/App.tsx Outdated Show resolved Hide resolved
frontend/src/pages/UserDetails.tsx Outdated Show resolved Hide resolved
backend/apps/github/api/user.py Outdated Show resolved Hide resolved
frontend/src/pages/UserDetails.tsx Outdated Show resolved Hide resolved
@harsh3dev harsh3dev requested a review from arkid15r January 8, 2025 17:27
@arkid15r arkid15r enabled auto-merge January 8, 2025 17:40
arkid15r
arkid15r approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arkid15r arkid15r added this pull request to the merge queue Jan 8, 2025
Merged via the queue into OWASP:main with commit f2cdcaa Jan 8, 2025
12 checks passed
@harsh3dev harsh3dev deleted the userdetail branch January 12, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r approved these changes

@kasya kasya Awaiting requested review from kasya kasya is a code owner

Assignees
No one assigned
Labels
backend frontend frontend-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement User details page
2 participants
@harsh3dev @arkid15r