Add mailing list attribute to project schema #749
Conversation
| @@ -54,6 +54,8 @@ def test_positive(project_schema): | |||
| "license-invalid-value.yaml", | |||
| "'INVALID-LICENSE-VALUE' is not one of ['AGPL-3.0', 'Apache-2.0', 'BSD-2-Clause', 'BSD-3-Clause', 'CC-BY-4.0', 'CC-BY-SA-4.0', 'CC0-1.0', 'EUPL-1.2', 'GPL-2.0', 'GPL-3.0', 'LGPL-2.1', 'LGPL-3.0', 'MIT', 'MPL-2.0', 'OTHER']", | |||
| ), | |||
| ("mailing_list-invalid.yaml", "'invalid-email' is not a valid email format"), | |||
There was a problem hiding this comment.
Replace this line of code with this ("mailing_list-none.yaml", "None is not of type 'string'"),
There was a problem hiding this comment.
replace this file name with mailing_list-none.yaml
There was a problem hiding this comment.
replace the file name with mailing_list-empty.yaml
| name: Leader Name 1 | ||
| - github: leader-name-2 | ||
| name: Leader Name 2 | ||
| level: 2 |
There was a problem hiding this comment.
after this line add mailing_list: ""
| name: Leader Name 1 | ||
| - github: leader-name-2 | ||
| name: Leader Name 2 | ||
| level: 2 |
There was a problem hiding this comment.
after this line add mailing_list:
|
And also add test case in |
|
The test was not running even before this changes ig @arkid15r |
I'm not sure what you mean. In any case your PR (as any other PR) must have all checks passed, including the tests. |
Resolves #701