-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cli for scaffolding a new challenge #802
Conversation
create the class file and asciidoc file Refs: #555
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow @nbaars this is a great start!
Thank you so much. I have some first feedback, can you please have a look at it ?
@@ -0,0 +1,10 @@ | |||
[package] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add this path to the dependabot configuration :)
|
||
## Building | ||
|
||
First install [Rust](https://www.rust-lang.org/tools/install). Then open a terminal and type: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can have a cross compiling and building github action with a download link to its attachments so people can copy it as well?
## Todo | ||
|
||
- Fix templating (not everything is present yet) | ||
- Add GitHub actions to build binary for the different platforms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes :D this!
}} | ||
|
||
@Component | ||
@Order(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make the order also automatede in terms o the number?
{{ | ||
extra_imports | ||
}} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/* | |
* <put your javadoc here describing the challenge in one sentence> | |
*/ |
public int difficulty() { | ||
return Difficulty.{{difficulty}}; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** | |
* {@inheritDoc} | |
* uses {{technology}}. | |
*/ |
} | ||
|
||
private String getData() { | ||
return "<<replace with correct answer>>"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return "<<replace with correct answer>>"; | |
return "<<replace with correct answer but then obfuscated/encrypted in code>>"; |
|
||
## Todo | ||
|
||
- Fix templating (not everything is present yet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice to have some basic tests as well i guess :) ? Can you add those please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow @nbaars this is a great start!
Thank you so much. I have some first feedback, can you please have a look at it ?
Elligible for |
Hi @nbaars ! Would you like to create a new iteration based on the refactor results please? |
Hi @nbaars should we keep this one open to generate the required files :-)? |
I'm going to rewrite this with Spring Boot CLI. Much cleaner approach. |
Still work in progress.
Refs: #555