Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cli for scaffolding a new challenge #802

Closed
wants to merge 6 commits into from
Closed

Conversation

nbaars
Copy link
Collaborator

@nbaars nbaars commented May 2, 2023

Still work in progress.

Refs: #555

@nbaars nbaars requested review from commjoen and bendehaan as code owners May 2, 2023 17:42
@nbaars nbaars marked this pull request as draft May 2, 2023 17:42
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow @nbaars this is a great start!
Thank you so much. I have some first feedback, can you please have a look at it ?

@@ -0,0 +1,10 @@
[package]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add this path to the dependabot configuration :)


## Building

First install [Rust](https://www.rust-lang.org/tools/install). Then open a terminal and type:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can have a cross compiling and building github action with a download link to its attachments so people can copy it as well?

## Todo

- Fix templating (not everything is present yet)
- Add GitHub actions to build binary for the different platforms
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes :D this!

}}

@Component
@Order(0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make the order also automatede in terms o the number?

{{
extra_imports
}}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/*
* <put your javadoc here describing the challenge in one sentence>
*/

public int difficulty() {
return Difficulty.{{difficulty}};
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
* {@inheritDoc}
* uses {{technology}}.
*/

}

private String getData() {
return "<<replace with correct answer>>";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return "<<replace with correct answer>>";
return "<<replace with correct answer but then obfuscated/encrypted in code>>";


## Todo

- Fix templating (not everything is present yet)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to have some basic tests as well i guess :) ? Can you add those please?

Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow @nbaars this is a great start!
Thank you so much. I have some first feedback, can you please have a look at it ?

@commjoen commjoen marked this pull request as ready for review May 17, 2023 06:48
@commjoen commjoen marked this pull request as draft May 18, 2023 04:09
@commjoen
Copy link
Collaborator

Elligible for hacktoberfest-accepted label if timely finished in october

@commjoen
Copy link
Collaborator

commjoen commented Dec 9, 2023

Hi @nbaars ! Would you like to create a new iteration based on the refactor results please?

@commjoen
Copy link
Collaborator

commjoen commented Jan 1, 2024

Hi @nbaars should we keep this one open to generate the required files :-)?

@nbaars
Copy link
Collaborator Author

nbaars commented Jan 17, 2024

I'm going to rewrite this with Spring Boot CLI. Much cleaner approach.

@nbaars nbaars closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants