Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the issue triage assignment wflow #521

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

GangGreenTemperTatum
Copy link
Collaborator

@GangGreenTemperTatum GangGreenTemperTatum commented Dec 27, 2024

PR Checklist 🚨

It is intended that only defined "vulnerability entry leads" should be able to create PR's (See CODEOWNERS and Core Team)

If you are not a CODEOWNER for the entry of artifact, please see our Issues and Discussions boards

Proposed changes

  • Enable workflow triggers for issue events
  • Fix token handling by moving to github-script's 'with' section
  • Add proper assignee deduplication and validation
  • Filter out 'TBC' placeholder assignees
  • Implement graceful error handling for invalid assignees
  • Add informative logging and issue comments for failures
  • Remove workflow failures on non-critical errors
  • Clean up duplicate GITHUB_TOKEN declaration

The workflow now properly handles edge cases and provides better feedback
when assignments fail, without interrupting the automation process.

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have x-referenced the appropriate issue this addresses within the projects board
  • I have applied the relevant labels this PR addresses

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@GangGreenTemperTatum GangGreenTemperTatum added the bug Factual inaccuracies, broken links, typos, etc label Dec 27, 2024
@GangGreenTemperTatum GangGreenTemperTatum merged commit baff712 into main Dec 27, 2024
2 checks passed
@GangGreenTemperTatum GangGreenTemperTatum deleted the ads/triage-issues-workflow-automation branch December 27, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Factual inaccuracies, broken links, typos, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant