OXDEV-8216: Refactor some DataProviders

OXID-eSales · Aug 12, 2024 · f48ea1f · f48ea1f
1 parent 78333ca
commit f48ea1f
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/tests/Unit/Module/Service/ModuleActivationsServiceTest.php b/tests/Unit/Module/Service/ModuleActivationsServiceTest.php
@@ -26,16 +26,16 @@ class ModuleActivationsServiceTest extends UnitTestCase
      */
     public function testModuleActivationAndDeactivation(
         string $method,
-        string $moduleId,
-        int $shopId
     ): void {
+        $shopId = 1;
+        $moduleId = uniqid();
         $moduleActivationBridgeMock = $this->createMock(ModuleActivationBridgeInterface::class);
         $moduleActivationBridgeMock
             ->method($method)
             ->with($moduleId, $shopId);
 
         $sut = $this->getSut(
-            context: $this->getContextMock(),
+            context: $this->getContextMock($shopId),
             moduleActivationBridge: $moduleActivationBridgeMock
         );
 
@@ -49,10 +49,9 @@ public function testModuleActivationAndDeactivation(
      */
     public function testModuleActivationAndDeactivationExceptions(
         string $method,
-        string $moduleId,
         mixed $exceptionClass
     ): void {
-
+        $moduleId = uniqid();
         $moduleActivationBridgeMock = $this->createMock(ModuleActivationBridgeInterface::class);
         $moduleActivationBridgeMock
             ->method($method)
@@ -72,29 +71,23 @@ public static function activationDataProvider(): \Generator
     {
         yield 'test activate module' => [
             'method' => 'activate',
-            'moduleId' => uniqid(),
-            'shopId' => 1
         ];
 
         yield 'test deactivate module' => [
             'method' => 'deactivate',
-            'moduleId' => uniqid(),
-            'shopId' => 1
         ];
     }
 
     public static function exceptionDataProvider(): \Generator
     {
         yield 'test activate module throws exception' => [
             'method' => 'activate',
-            'moduleId' => uniqid(),
             'exceptionClass' => ModuleActivationException::class,
 
         ];
 
         yield 'test deactivate module throws exception' => [
             'method' => 'deactivate',
-            'moduleId' => uniqid(),
             'exceptionClass' => ModuleDeactivationException::class,
 
         ];