OXDEV-8715 Environment loader without file

OXID-eSales · Jan 21, 2025 · 31d60ec · 31d60ec
1 parent eed3cf8
commit 31d60ec
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 4 deletions.
diff --git a/source/Internal/Framework/Env/DotenvLoader.php b/source/Internal/Framework/Env/DotenvLoader.php
@@ -10,24 +10,32 @@
 namespace OxidEsales\EshopCommunity\Internal\Framework\Env;
 
 use Symfony\Component\Dotenv\Dotenv;
+use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\Filesystem\Path;
 
 class DotenvLoader
 {
     private string $envKey = 'OXID_ENV';
     private string $envFile = '.env';
 
-    public function __construct(private readonly string $pathToEnvFiles)
+    public function __construct(
+        private readonly string $pathToEnvFiles
+    )
     {
     }
 
     public function loadEnvironmentVariables(): void
     {
+        $filesystem = new Filesystem();
+        $envFilePath = Path::join($this->pathToEnvFiles, $this->envFile);
+
+        if (!$filesystem->exists($envFilePath)) {
+            return;
+        }
+
         $dotEnv = new Dotenv($this->envKey);
         $dotEnv
             ->usePutenv()
-            ->loadEnv(
-                Path::join($this->pathToEnvFiles, $this->envFile)
-            );
+            ->loadEnv($envFilePath);
     }
 }
diff --git a/tests/Integration/Internal/Framework/Env/EnvLoaderTest.php b/tests/Integration/Internal/Framework/Env/EnvLoaderTest.php
@@ -9,6 +9,7 @@
 
 namespace OxidEsales\EshopCommunity\Tests\Integration\Internal\Framework\Env;
 
+use OxidEsales\EshopCommunity\Internal\Framework\Env\DotenvLoader;
 use OxidEsales\EshopCommunity\Tests\ContainerTrait;
 use OxidEsales\EshopCommunity\Tests\EnvTrait;
 use PHPUnit\Framework\TestCase;
@@ -41,11 +42,22 @@ public function tearDown(): void
 
     public function testApplicationEnvironmentIsDefined(): void
     {
+        $this->loadEnvFixture($this->fixtures, ["key=value"]);
+
         $currentEnvironment = getenv($this->appEnvKey);
 
         $this->assertNotEmpty($currentEnvironment);
     }
 
+    public function testLoadNonExistentEnvironmentFile(): void
+    {
+        $dotenvLoader = new DotenvLoader('non-existent-path');
+
+        $this->expectNotToPerformAssertions();
+
+        $dotenvLoader->loadEnvironmentVariables();
+    }
+
     public function testApplicationEnvironmentCanBeRedefined(): void
     {
         $someValue = uniqid('some-value', true);