Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking PR for write-functionality branch #1

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

Tracking PR for write-functionality branch #1

wants to merge 33 commits into from

Conversation

Oakchris1955
Copy link
Owner

This pull request will track the progress of the write-functionality branch, which has aims to properly implement write functionality for the library

@Oakchris1955 Oakchris1955 self-assigned this Aug 18, 2024
@Oakchris1955
chore: remove unnecessary impl
c689a64
@Oakchris1955
fix: seeking on a File wouldn't always happen correctly
9775f2a
@Oakchris1955
feat(truncate): Public function to truncate a File down to a given size
6bd3534
@Oakchris1955
fix: also write FAT entries to the FAT table copies
a8ced4c
@Oakchris1955
fix: fix commit a8ced4c for no-std contexts
4941c8c
@Oakchris1955
chore: writing FAT12 entries no longer reads sectors ahead-of-time
ad6747e 
When writing a FATEntry on a FAT12 filesystem, the bytes the entry spans would be read ahead-of-time & OR-ed to the new entry's bytes. This is no longer the case. FAT12 still reads those bytes since FAT12 entries are 1.5 bytes long, but now they are read individually just before the new byte is written.
@Oakchris1955
feat(file): split File struct into separate ROFile & RWFile
20adcf0
@Oakchris1955
fix: correctly implement file attributes
f427f9e 
There's no reason to expose the VOLUME_ID or the LFN attribute to the end user
@Oakchris1955
Copy link
Owner Author

I’d just like to interject for a moment. Just because this branch is named write-functionality, it doesn't mean that all commits here are write-related. Instead, certain commits, like f427f9e for example, make it easier to implement such behaviour.

@Oakchris1955
fix: correctly parse 8.3 & LFN entries that span multiple sectors
21d83d6 
Also, made code more clear & removed unnecessary `unsafe` keywords
@Oakchris1955
feat: add remove() method to RWFile struct
f88942b
@Oakchris1955
fix: truncate() now works if the new size is close to the old one
a60e55b
@Oakchris1955
fix(fat32): various fat32-related bug fixes
d8a5cfd 
Due to those bugs, it would be impossible to actually use this library on a FAT32 filesystem
@Oakchris1955
test(fat32): create various fat32-related tests
418451a
@Oakchris1955
refactor: split fs.rs file into multiple modules
8b61fea
@Oakchris1955
chore: various aesthetic changes
a4503de 
Consider this a followup to 8b61fea
@Oakchris1955
fix: properly handle FATs
b891cc0 
Mirroring is now properly implemented & sector writes are limited near the theoretical minimum
@Oakchris1955
chore: rename src/fs/ to src/fat/
d43d06a
@Oakchris1955
fix: correctly handle calling RW methods on RO storage mediums
66b1f78
@Oakchris1955
chore: create a proper constructor for the FSProperties struct
9e61bd8
@Oakchris1955
chore: Update README.md
fa7380d
@Oakchris1955
refactor: minor entry chain-related changes
5fb88c9
@Oakchris1955
refactor: create modularized internal remove-related methods
de85609 
There is no need for these things to be part of the truncate method and not of the Filesystem struct
@Oakchris1955 Oakchris1955 marked this pull request as draft September 8, 2024 12:46
@Oakchris1955
Copy link
Owner Author

Should have been a draft PR in the first place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Oakchris1955 Oakchris1955

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Oakchris1955