Skip to content

Commit

Permalink
Sensible names
Browse files Browse the repository at this point in the history
Made the action names for moving the bot "up" and "down" instead of "open" and "closed"
  • Loading branch information
EuphoniumPlayer committed Mar 11, 2024
1 parent 89a1899 commit a3f9d38
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/main/java/frc/robot/commands/ElevatorControl.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ public void initialize() {}
@Override
public void execute() {
if (ElevatorJoystick.getThrottle() <= 15) {
ElevatorSubsystem.open();
ElevatorSubsystem.up();
} else if (ElevatorJoystick.getThrottle() >= 85) {
ElevatorSubsystem.close();
ElevatorSubsystem.down();
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/main/java/frc/robot/subsystems/Elevator.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ public Elevator() {
}

/** Open pistons to go up */
public void open() {
public void up() {
doubleSolenoid.set(DoubleSolenoid.Value.kForward);
SmartDashboard.putBoolean(getName(), true);
}

/** Closes pistons to go down */
public void close() {
public void down() {
doubleSolenoid.set(DoubleSolenoid.Value.kReverse);
SmartDashboard.putBoolean(getName(), false);
}
Expand Down

0 comments on commit a3f9d38

Please sign in to comment.