Lw/6242 fix hh tasks v2 #145
Conversation
adamskrodzki
changed the base branch from
automation_v2
to
as/automation_v2_merged
johnnieskywalker
changed the base branch from
as/automation_v2_merged
to
automation_v2
| console.log(!activeTriggerIds.length) | ||
| console.log('Array.isArray(activeTriggerIds) && activeTriggerIds.length !== 0') | ||
| console.log(Array.isArray(activeTriggerIds) && activeTriggerIds.length !== 0) | ||
| triggerIdToReplace = |
There was a problem hiding this comment.
this was returning -Infinity for an empty array
How to testTry adding all types of triggers for vault you own on goerli. Here are example command calls and transactions. Stop loss to coll
Stop Loss to DAI
Auto buy
Auto sell
Take Profit to Collateral
Take Profit to DAI
Test pessimistic scenarios for example not existing triggerIDs expect clear error message
beware gas estimation issues etc |
adding buy and sell trigger is fixed
output of
npx hardhat create-trigger --vault 433 --type 3 --params '[40000,30000,'0',true,100,200]' --network goerlinpx hardhat create-trigger --vault 433 --type 4 --params '[40000,30000,'0',true,100,200]' --network goerliTBD fix for creating all the triggers