feat: transient storage support in DMA
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerotucks
approved these changes
Apr 12, 2024
zerotucks
requested changes
Apr 12, 2024
halaprix
force-pushed
the
kk/sc-15129/sc-operation-executor-gas-optimizations
branch
from
4984dd6
to
f3c903c
Compare
…ixes fix: post audit fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket URL
Please provide a link to the ticket:
Description of Changes
CURRENT - OasisDEX/oasis-earn-sc@cc676ee
GAS OPTIMIZED v1 - used by automation - f4c2dd7
TRANSIENT STORAGE - this version
Please list the changes introduced by this PR:
UseStorageSlotlibrarytstoreandtloadto optimize gas usage for action hashes storage and values stored during operation executionWriteandReadlibraries in to oneStorageSlotlibraryusing StorageSlot for bytes32;to access the stored array - where thebytes32type variable defines slot address where the array is locatedstoreInSlot("transaction")andstoreInSlot("actions")can be used to get the slot position foractionsandtransactionarrays respectively - this can be used to create additional arrays, or the library can be further expanded to support multiple data typesHow to Test
Please provide instructions on how to test the changes in this PR:
PR Definition of Done
Please ensure the following requirements have been met before marking the PR as ready for review: