Revert "Set NODE_ENV on staging to staging (#3480)" (#3482)

This reverts commit 44699d4.
OasisDEX · Feb 2, 2024 · 59d5527 · 59d5527
1 parent 44699d4
commit 59d5527
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 8 deletions.
diff --git a/.github/workflows/aws-staging.yaml b/.github/workflows/aws-staging.yaml
@@ -106,7 +106,7 @@ jobs:
           ETHERSCAN_API_KEY: ${{ secrets.ETHERSCAN_API_KEY }}
           BLOCKNATIVE_API_KEY: ${{ secrets.BLOCKNATIVE_API_KEY_STAGING }}
           SHOW_BUILD_INFO: 1
-          NODE_ENV: staging
+          NODE_ENV: production
           NEXT_PUBLIC_SENTRY_ENV: staging
           SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
           PRODUCT_HUB_KEY: ${{ secrets.PRODUCT_HUB_KEY }}

diff --git a/blockchain/networks/get-rpc-provider.ts b/blockchain/networks/get-rpc-provider.ts
@@ -82,7 +82,7 @@ export function getBackendRpcProvider(networkId: NetworkIds): JsonRpcBatchProvid
     skipCache: false,
     skipMulticall: false,
     skipGraph: true,
-    stage: process.env.NODE_ENV !== 'development' ? 'prod' : 'dev',
+    stage: process.env.NODE_ENV === 'production' ? 'prod' : 'dev',
     source: 'backend',
   }
 

diff --git a/blockchain/networks/network-helpers.ts b/blockchain/networks/network-helpers.ts
@@ -9,7 +9,7 @@ import type { NetworkConfig, NetworkConfigHexId } from './networks-config'
 import { networks, networksById } from './networks-config'
 
 export const isTestnetEnabled = () => {
-  const isDev = env.NODE_ENV === 'development'
+  const isDev = env.NODE_ENV !== 'production'
   const showTestnetsParam =
     window && new URLSearchParams(window.location.search).get('testnets') !== null
   return isDev || showTestnetsParam

diff --git a/blockchain/networks/networks-config.ts b/blockchain/networks/networks-config.ts
@@ -83,7 +83,7 @@ export function contractDesc(
 export function emptyContractDesc(contractName: string): ContractDesc & { genesisBlock: number } {
   // not every contract is available on every network
   // hence this function is used to return an empty contract
-  env.NODE_ENV !== 'production' && console.warn('Contract not set:', contractName)
+  env.NODE_ENV === 'development' && console.warn('Contract not set:', contractName)
   return { abi: {}, address: '', genesisBlock: 0 }
 }
 

diff --git a/contentful/api.ts b/contentful/api.ts
@@ -6,7 +6,7 @@ export async function fetchGraphQL<T>(query: (preview: boolean) => string): Prom
   const previewAccessToken =
     getConfig()?.publicRuntimeConfig?.contentfulPreviewAccessToken ||
     process.env.CONTENTFUL_PREVIEW_ACCESS_TOKEN
-  const preview = process.env.NODE_ENV !== 'production'
+  const preview = process.env.NODE_ENV === 'development'
 
   return fetch(
     `https://graphql.contentful.com/content/v1/spaces/${process.env.CONTENTFUL_SPACE_ID}`,

diff --git a/next-i18next.config.js b/next-i18next.config.js
@@ -2,11 +2,12 @@ const HttpBackend = require('i18next-http-backend/cjs')
 const HMRPlugin =
   process.env.NODE_ENV !== 'production' ? require('i18next-hmr/plugin').HMRPlugin : undefined
 
+const isProd = process.env.NODE_ENV === 'production'
 const isDev = process.env.NODE_ENV === 'development'
 const windowDefined = typeof window !== 'undefined'
 
 const hmrConfig =
-  !isDev && windowDefined
+  !isProd && windowDefined
     ? [HttpBackend, new HMRPlugin({ webpack: { client: true } })]
     : [HMRPlugin ? new HMRPlugin({ webpack: { server: true } }) : undefined]
 
@@ -24,5 +25,5 @@ module.exports = {
     : {}),
   serializeConfig: false,
   reloadOnPrerender: isDev,
-  use: isDev ? hmrConfig : [],
+  use: !isProd ? hmrConfig : [],
 }
diff --git a/server/prisma.ts b/server/prisma.ts
@@ -6,7 +6,7 @@ type GlobalThisWithPrismaClient = typeof globalThis & {
 }
 
 function getPrismaClient() {
-  if (process.env.NODE_ENV !== 'development') {
+  if (process.env.NODE_ENV === `production`) {
     return new PrismaClient()
   } else {
     const newGlobalThis = globalThis as GlobalThisWithPrismaClient