Earn protocol WIP #20 #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #559 +/- ##
==========================================
- Coverage 72.16% 70.16% -2.01%
==========================================
Files 159 129 -30
Lines 1710 1354 -356
Branches 108 78 -30
==========================================
- Hits 1234 950 -284
+ Misses 471 404 -67
+ Partials 5 0 -5 ☔ View full report in Codecov by Sentry. |
… useAmount hook for better amount display handling
piekczyk
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
20 of N pull requests.
This pull request introduces several enhancements to the
apps/earn-protocolapplication, focusing on incorporating user activity data and top depositors into various pages and components. The most important changes include updates to theEarnVaultManagePage,EarnVaultOpenPage, andUserActivityPageto fetch and display this new data, as well as modifications to the server handlers and components to support these updates.Enhancements to data fetching and display:
apps/earn-protocol/app/earn/[network]/position/[vaultId]/[walletAddress]/page.tsx: AddedgetUserActivityto fetch user activity and top depositors, and updatedEarnVaultManagePageto include this data in the component props. (apps/earn-protocol/app/earn/[network]/position/[vaultId]/[walletAddress]/page.tsxR6, apps/earn-protocol/app/earn/[network]/position/[vaultId]/[walletAddress]/page.tsxL22-R23, apps/earn-protocol/app/earn/[network]/position/[vaultId]/[walletAddress]/page.tsxR34-R38, apps/earn-protocol/app/earn/[network]/position/[vaultId]/[walletAddress]/page.tsxR65-R66)apps/earn-protocol/app/earn/[network]/position/[vaultId]/page.tsx: UpdatedEarnVaultOpenPageto fetch user activity and top depositors and pass this data to theVaultOpenViewcomponent. (apps/earn-protocol/app/earn/[network]/position/[vaultId]/page.tsxR4, apps/earn-protocol/app/earn/[network]/position/[vaultId]/page.tsxL18-R25, apps/earn-protocol/app/earn/[network]/position/[vaultId]/page.tsxL34-R43)apps/earn-protocol/app/earn/user-activity/page.tsx: ModifiedUserActivityPageto include top depositors in the fetched data and pass it to theUserActivityViewcomponent. [1] [2]Updates to server handlers:
apps/earn-protocol/app/server-handlers/sdk/get-user-activity.ts: Created a new functiongetUserActivityto fetch user activity and top depositors.apps/earn-protocol/app/server-handlers/sdk/get-users-activity.ts: UpdatedgetUsersActivityto include top depositors in the returned data. [1] [2] [3]Component modifications:
apps/earn-protocol/components/layout/VaultManageView/VaultManageView.tsx: UpdatedVaultManageViewto accept and pass user activity and top depositors to theVaultManageViewComponent. [1] [2] [3]apps/earn-protocol/components/layout/VaultManageView/VaultManageViewComponent.tsx: EnhancedVaultManageViewComponentto display user activity, top depositors, and other related data. [1] [2] [3] [4] [5] [6] [7] [8]apps/earn-protocol/components/layout/VaultOpenView/VaultOpenView.tsx: UpdatedVaultOpenViewto accept and pass user activity and top depositors to theVaultOpenViewComponent. [1] [2]