updated disaggregation section #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sambles
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Worth linking over to https://oasislmf.github.io/sections/pytools.html#gulmc and adding some of the deleted sections there (if useful)
src/sections/disaggregation.rst
Outdated
| The model provider could instead use the disagg_id field for hazard grouping, to assign independent hazard groups to both | ||
| IsAggregate cases, in cases of a highly localized peril where 100% hazard correlation cannot be assumed, even for a campus. | ||
|
|
||
| "modelpy": true, |
There was a problem hiding this comment.
I think this should be "modelpy": false, since its not used with gulmc?
There was a problem hiding this comment.
Yes have tested removal of both modelpy: false and gulpy: false in oasislmf settings when using gulmc=true, and it works and produces same results, so I think they are not necessary.
johcarter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganised disaggregation section to list features by Oasis LMF version