-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completed correlation section #22
Conversation
johcarter
commented
Nov 1, 2023
- Separated features by OasisLMF version
- completed correlation documentation for 1.27 and 1.28
|
src/sections/correlation.rst
Outdated
.. code-block:: JSON | ||
|
||
"data_settings": { | ||
"damage_group_fields": ["PortNumber", "AccNumber", "LocNumber"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray }
in code block which should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor fixes for the model_settings.json code snippets
src/sections/correlation.rst
Outdated
"damage_group_fields": ["PortNumber", "AccNumber", "LocNumber"] }, | ||
"hazard_group_fields": ["areaperil_id"] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray }
in code block which should be removed
src/sections/correlation.rst
Outdated
"damage_group_fields": ["PortNumber", "AccNumber", "LocNumber", "coverage_type_id"] }, | ||
"hazard_group_fields": ["PortNumber", "AccNumber", "LocNumber"] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray }
in code block which should be removed
src/sections/correlation.rst
Outdated
"damage_group_fields": ["PortNumber", "AccNumber", "LocNumber", "coverage_type_id"] }, | ||
"hazard_group_fields": ["PortNumber", "AccNumber", "LocNumber"] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray }
in code block which should be removed
src/sections/correlation.rst
Outdated
"damage_group_fields": ["PortNumber", "AccNumber", "LocNumber", "coverage_type_id"] }, | ||
"hazard_group_fields": ["PortNumber", "AccNumber", "LocNumber"] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray }
in code block which should be removed
src/sections/correlation.rst
Outdated
"damage_group_fields": ["PortNumber", "AccNumber", "LocNumber"] }, | ||
"hazard_group_fields": ["PortNumber", "AccNumber", "LocNumber"] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray }
in code block which should be removed
Thanks @sambles , I have ran all json blobs through a parser and think they are all correct now. thanks for spotting that. |