Completed correlation section #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johcarter
commented
Nov 1, 2023
johcarter
commented
- Separated features by OasisLMF version
- completed correlation documentation for 1.27 and 1.28
|
sambles
reviewed
Nov 2, 2023
src/sections/correlation.rst
Outdated
| .. code-block:: JSON | ||
|
|
||
| "data_settings": { | ||
| "damage_group_fields": ["PortNumber", "AccNumber", "LocNumber"] } |
There was a problem hiding this comment.
Stray } in code block which should be removed
sambles
approved these changes
Nov 2, 2023
src/sections/correlation.rst
Outdated
Comment on lines
426
to
427
| "damage_group_fields": ["PortNumber", "AccNumber", "LocNumber"] }, | ||
| "hazard_group_fields": ["areaperil_id"] }, |
There was a problem hiding this comment.
Stray } in code block which should be removed
src/sections/correlation.rst
Outdated
Comment on lines
445
to
446
| "damage_group_fields": ["PortNumber", "AccNumber", "LocNumber", "coverage_type_id"] }, | ||
| "hazard_group_fields": ["PortNumber", "AccNumber", "LocNumber"] }, |
There was a problem hiding this comment.
Stray } in code block which should be removed
src/sections/correlation.rst
Outdated
Comment on lines
463
to
464
| "damage_group_fields": ["PortNumber", "AccNumber", "LocNumber", "coverage_type_id"] }, | ||
| "hazard_group_fields": ["PortNumber", "AccNumber", "LocNumber"] }, |
There was a problem hiding this comment.
Stray } in code block which should be removed
src/sections/correlation.rst
Outdated
Comment on lines
493
to
494
| "damage_group_fields": ["PortNumber", "AccNumber", "LocNumber", "coverage_type_id"] }, | ||
| "hazard_group_fields": ["PortNumber", "AccNumber", "LocNumber"] }, |
There was a problem hiding this comment.
Stray } in code block which should be removed
src/sections/correlation.rst
Outdated
Comment on lines
522
to
523
| "damage_group_fields": ["PortNumber", "AccNumber", "LocNumber"] }, | ||
| "hazard_group_fields": ["PortNumber", "AccNumber", "LocNumber"] }, |
There was a problem hiding this comment.
Stray } in code block which should be removed
|
Thanks @sambles , I have ran all json blobs through a parser and think they are all correct now. thanks for spotting that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.