Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PLA in analysis_settings #159

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Enable PLA in analysis_settings #159

merged 1 commit into from
Sep 18, 2023

Conversation

sambles
Copy link
Contributor

@sambles sambles commented Sep 18, 2023

Enable PLA in analysis Settings

In #141 the expected results files were updated to execute with PLA enabled.

In OasisLMF/OasisLMF#1369 PLA can now be explicitly enabled/disabled in the analysis_settings.json using the boolean option.

"pla": true,

If no value is given, PLA == False, updated the Piwind analysis settings examples to switch back on PLA so piwind passes CI

@sambles sambles merged commit 457581f into main Sep 18, 2023
6 checks passed
@sambles sambles deleted the fix/enable-pla-feature branch September 18, 2023 10:42
sambles added a commit that referenced this pull request Oct 3, 2023
sambles added a commit that referenced this pull request Oct 3, 2023
* Remove amplification from the lookup config

* disable pla

* Revert "Enable PLA in analysis_settings (#159)"

This reverts commit 457581f.

* Revert expected changes from PLA

* clear stray file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant