Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to handle exceptions which can't be serialized by celery #1073

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Fix to handle exceptions which can't be serialized by celery #1073

merged 2 commits into from
Jul 2, 2024

Conversation

sambles
Copy link
Contributor

@sambles sambles commented Jul 2, 2024 •
edited
Loading

Fix to handle exceptions which can't be serialized by celery

  • Celery can fail to log exceptions which are not pickable or serializable. Added exception logging within the V2 worker task file in case this happens (workaround).
  • Added check in worker-monitor v2 to make sure the trackback from sub-tasks is not set to None

@sambles sambles changed the title Make sure TB is not none and log all exceptions within worker Fix to handle exceptions which can't be serialized Jul 2, 2024
@sambles sambles linked an issue Jul 2, 2024 that may be closed by this pull request
Always mark Sub-tasks as error when hitting problems #1072
Closed
@sambles sambles self-assigned this Jul 2, 2024
@sambles sambles changed the title Fix to handle exceptions which can't be serialized Fix to handle exceptions which can't be serialized by celery Jul 2, 2024
@sambles sambles merged commit 1762a77 into main Jul 2, 2024
27 checks passed
@sambles sambles deleted the fix/1072-custom-keys-errors-V2 branch July 2, 2024 16:09
sambles added a commit that referenced this pull request Jul 2, 2024
@sambles
Fix to handle exceptions which can't be serialized by celery (#1073)
846aac3 
* Make sure TB is not none and log any exections within worker

* re-raise
@sambles sambles mentioned this pull request Jul 2, 2024
Merged
1 task
@awsbuild awsbuild added this to the 2.3.6 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sambles sambles

Labels
bug LTS - 2.3
Projects
Oasis Dev Team Tasks
Status: Done
Milestone
2.3.6
Development

Successfully merging this pull request may close these issues.

Always mark Sub-tasks as error when hitting problems
2 participants
@sambles @awsbuild