Added chunking options to analysis level #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambles
added a commit
that referenced
this pull request
Jan 15, 2024
* Add missing check for build up of queue messages * First pass * Attach chunking options to analyses model * Add chunking endpoints to analysis * Set task-controller to check both model and analysis chunking options * PEP * flake * Add migrations * update tests * Add env var to disable v2 api * f] * remove special case -- chunk=1 now means run losses in a single ktools pipe * Debug prints * Read chunking options from analysis when running job validation * fix & pep * f * Fixed -- removed debug logging * Remove logging * Update test expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added chunking options to analysis level
Added a new endpoint
/v2/analyses/{id}/chunking_configuration/this uses the same Django model as/v2/models/{id}/chunking_configuration/, ModelChunkingOptions , but only applies to a single analysis.Usage
On analyses creation the value of
chunking_configurationis equal toNone, if not set then the options are read at the model level/v2/models/{id}/chunking_configuration/.After a POST to
/v2/analyses/{id}/chunking_configuration/the analysis{id}will have its own chunking options which now overrides the default from the model level.Related fixes
OASIS_DISABLE_V2_API={True|False}, when set totruethe v2 endpoints are disabled and the server can only run analysis insingle serverexecution (intended for docker-compose or debugging)