Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging fixes for workers (#994) - 1.27 #998

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

sambles
Copy link
Contributor

@sambles sambles commented Mar 18, 2024

Logging fixes for workers (#994)

  • Fixed input generation logs lost on OOM - #798

sambles and others added 2 commits March 18, 2024 18:07
* first pass - refactor input gen call and logging

* Fix exceptions not logged by worker monitor

* remove test exception

* Call generate losses from python instead of bash

* fix logger calls

* wip

* test refactor

* tmp

* Add sub-task error logs to main analysis error trace

* concat output logs on input gen success

* Fix v2 worker gen files

* Fix losses gen traceback

* Fix V1 worker logging

* Fix CI docker log storage

* Fix

* Fix tests

* flak8

* Fix debug logging level

* wip - fix missing ktools log tar

* Fix missing ktools log tar

* pep

* Clean up task log files on exit

* Fix traceback filenames v2
@sambles sambles changed the base branch from main to release/1.27.9 March 18, 2024 18:08
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@sambles sambles linked an issue Mar 19, 2024 that may be closed by this pull request
@sambles sambles merged commit 7cdec9f into release/1.27.9 Mar 19, 2024
18 checks passed
@sambles sambles deleted the fix/worker-logging-v1-1.27 branch March 19, 2024 10:53
@awsbuild awsbuild added this to the 1.27.9 milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lost analyses logs when a task fails from exit code - v1 workers
2 participants