holesky ready cdvn #254
Merged
holesky ready cdvn #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinebit
reviewed
Feb 8, 2024
There was a problem hiding this comment.
I found it useful to set depends_on: for at least preventing starting other services. This keeps the log clearer, otherwise some services are restarting and therefore confusing for the user.
There was a problem hiding this comment.
@pinebit do you think we should add depends_on: for charon depending on lighthouse? which ones specifically you mean?
pinebit
approved these changes
Feb 8, 2024
dB2510
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
holeskyas the default network in CDVNgethwithnethermindas the default EL client