Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting prometheus config to use env variables #260

Merged
merged 19 commits into from
May 3, 2024
Merged

Setting prometheus config to use env variables #260

merged 19 commits into from
May 3, 2024

Conversation

haroldsphinx
Copy link
Contributor

  • Enable prometheus --config-expand in docker-compose.yml to allow operator specify a unique label that can be used to identify their nodes and help obol route alerts to specific node operators

@haroldsphinx
Update proemtheus config
be027df 
Signed-off-by: haroldsphinx <[email protected]>
@haroldsphinx
Tested and it works fine
1ee3973 
Signed-off-by: haroldsphinx <[email protected]>
@haroldsphinx
Tested and it works fine
24623f6 
Signed-off-by: haroldsphinx <[email protected]>
@haroldsphinx
Add alert setup integration
b26cb38 
Signed-off-by: haroldsphinx <[email protected]>
LukeHackett12
LukeHackett12 requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@LukeHackett12 LukeHackett12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all these alerts are linked to m1 cluster, does not make sense. Will change this

@haroldsphinx
Copy link
Contributor Author

haroldsphinx commented Mar 19, 2024 via email

@LukeHackett12 LukeHackett12 merged commit aef9a6f into main May 3, 2024
1 check passed
@LukeHackett12 LukeHackett12 deleted the prometheus-config-expand branch May 3, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenowits xenowits xenowits approved these changes

@LukeHackett12 LukeHackett12 LukeHackett12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haroldsphinx @LukeHackett12 @xenowits