Update CDVN with latest changes found in LCDVN #283
Conversation
KaloyanTanev
force-pushed
the
kalo/update-cdvn-with-latest-changes
branch
from
ac35e6c to
b9e9aab
Compare
| To run the default example, use the following command: | ||
|
|
||
| ``` | ||
| docker compose -f examples/nethermind_teku_lighthouse.yml up | ||
| ```sh | ||
| docker compose up | ||
| ``` |
There was a problem hiding this comment.
Don't we have to say
cp .env.holesky .env
docker compose up -d
There was a problem hiding this comment.
I haven't paid much attention to the readme. I planned to get this and the other PRs merged and then update it accordingly. IMO there are many things to be improved in it.
There was a problem hiding this comment.
This all looks pretty good bar one rm -rf, however, I suspect this changes our quickstart guides, and maybe even our launchpad flows. We don't have that cp .env.holesky expectation places.
Lets consider if we are open to taking on the work of changing that everywhere for the clean up it brings.
(Similarly, I'll have the same feedback about the next PR, where i'm unsure we should take the lift and issues for a final cohort.
|
To be merged on charon v1.1.1 release, as we'd like to have this docs PR released as well. |
KaloyanTanev
force-pushed
the
kalo/update-cdvn-with-latest-changes
branch
from
4846d29 to
d08f4d5
Compare
Update CDVN with latest changes found in LCDVN.
Add example with holesky and do not treat holesky as the default in the docker compose.
Update the readme.
ticket: #285