github: fix build push build arg format #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update cluster config changelog for new config versions. category: docs ticket: #2307
Fixes the github action "build-push-deploys" `build-args` parameter. It is a [list parameter that is new line delimited](https://github.com/docker/build-push-action#inputs). Also remove `-a` build arg since it isn't required. Make it explicit that `GO_BUILD_FLAG` only supports a single flag. This ports the fix from `main-v0.16` release branch to main. category: misc ticket: #2270
github-actions
bot
added
the
branch-release
xenowits
added
the
merge when ready
corverroos
approved these changes
Jul 28, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main-v0.17 #2484 +/- ##
==============================================
- Coverage 53.64% 53.53% -0.11%
==============================================
Files 198 198
Lines 26756 26756
==============================================
- Hits 14352 14325 -27
- Misses 10619 10646 +27
Partials 1785 1785
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the github action "build-push-deploys"
build-argsparameter. It is a list parameter that is new line delimited.Also remove
-abuild arg since it isn't required. Make it explicit thatGO_BUILD_FLAGonly supports a single flag.This ports the fix from
main-v0.16release branch tomain-v0.17.category: misc
ticket: #2270