Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: allow deposits greater than 32eth #3279

Closed
wants to merge 1 commit into from

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Sep 12, 2024

Currently the maximum allowed deposit is 32 ETH both in create cluster and in create dkg. We want to allow deposits larger than 32 ETH per validator. The maximum is to be set to 2048 ETH.

category: feature
ticket: #3278

Copy link

sonarcloud bot commented Sep 12, 2024

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.66%. Comparing base (6eb8442) to head (f5aacd2).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cmd/createcluster.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3279      +/-   ##
==========================================
+ Coverage   57.63%   57.66%   +0.02%     
==========================================
  Files         211      211              
  Lines       30418    30421       +3     
==========================================
+ Hits        17532    17542      +10     
+ Misses      10997    10990       -7     
  Partials     1889     1889              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinebit pinebit added the do not merge Indicate to bulldozer bot that this PR should not be merged label Sep 13, 2024
@pinebit pinebit closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicate to bulldozer bot that this PR should not be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants