-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dockerfile): optimized Dockerfile #3281
Open
No0key
wants to merge
4
commits into
ObolNetwork:main
Choose a base branch
from
No0key:fix-dockerfile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c9accc6
fix(dockerfile): optimized dockerfile, removed additional docker layers
No0key dedc93e
fix(dockerfile): fix pr comments
No0key 4af1fc3
Merge branch 'main' of github.com:No0key/charon into fix-dockerfile
No0key 8ee649e
fix(dockerfile): fix pr comments
No0key File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,22 @@ | ||
# Container for building Go binary. | ||
FROM golang:1.23.1-bookworm AS builder | ||
|
||
# Install dependencies | ||
RUN apt-get update && apt-get install -y build-essential git | ||
RUN apt-get update && apt-get install -y --no-install-recommends build-essential git \ | ||
&& rm -rf /var/lib/apt/lists/* | ||
|
||
# Prep and copy source | ||
WORKDIR /app/charon | ||
COPY go.mod go.sum ./ | ||
RUN go mod download | ||
No0key marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
COPY . . | ||
|
||
# Populate GO_BUILD_FLAG with a build arg to provide an optional go build flag. | ||
ARG GO_BUILD_FLAG | ||
ENV GO_BUILD_FLAG=${GO_BUILD_FLAG} | ||
RUN echo "Building with GO_BUILD_FLAG='${GO_BUILD_FLAG}'" | ||
|
||
# Build with Go module and Go build caches. | ||
RUN \ | ||
--mount=type=cache,target=/go/pkg \ | ||
|
@@ -18,33 +26,41 @@ | |
|
||
# Copy final binary into light stage. | ||
FROM debian:bookworm-slim | ||
RUN apt-get update && apt-get install -y ca-certificates wget fio | ||
RUN apt-get update && apt-get install -y --no-install-recommends ca-certificates wget fio \ | ||
Check notice Code scanning / SonarCloud Arguments in long RUN instructions should be sorted Low
Sort these package names alphanumerically. See more on SonarCloud
|
||
&& rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* | ||
ARG GITHUB_SHA=local | ||
ENV GITHUB_SHA=${GITHUB_SHA} | ||
|
||
COPY --from=builder /app/charon/charon /usr/local/bin/ | ||
|
||
# Don't run container as root | ||
ENV USER=charon | ||
ENV UID=1000 | ||
ENV GID=1000 | ||
RUN addgroup --gid "$GID" "$USER" | ||
RUN adduser \ | ||
RUN addgroup --gid "$GID" "$USER" \ | ||
&& adduser \ | ||
--disabled-password \ | ||
--gecos "charon" \ | ||
--home "/opt/$USER" \ | ||
--ingroup "$USER" \ | ||
--no-create-home \ | ||
--uid "$UID" \ | ||
"$USER" | ||
RUN chown charon /usr/local/bin/charon | ||
RUN chmod u+x /usr/local/bin/charon | ||
"$USER" \ | ||
&& chown $USER /usr/local/bin/charon \ | ||
&& chmod u+x /usr/local/bin/charon \ | ||
&& mkdir -p "/opt/$USER" \ | ||
&& chown $USER "/opt/$USER" | ||
|
||
WORKDIR "/opt/$USER" | ||
RUN chown charon "/opt/$USER" | ||
USER charon | ||
|
||
ENTRYPOINT ["/usr/local/bin/charon"] | ||
CMD ["run"] | ||
|
||
# Used by GitHub to associate container with repo. | ||
LABEL org.opencontainers.image.source="https://github.com/obolnetwork/charon" | ||
LABEL org.opencontainers.image.title="charon" | ||
LABEL org.opencontainers.image.description="Proof of Stake Ethereum Distributed Validator Client" | ||
LABEL org.opencontainers.image.licenses="GPL v3" | ||
LABEL org.opencontainers.image.documentation="https://github.com/ObolNetwork/charon/tree/main/docs" | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary, as this is multi-stage build and the image from the first stage is not used in the final image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the cache deletion, but now the code quality test suggests that the cache must be cleared, is that ok?