Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: enable exit all #3296

Merged
merged 1 commit into from
Oct 1, 2024
Merged

cmd: enable exit all #3296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions cmd/exit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@
return s
}

//nolint:exhaustive // `all` is not yet implemented
switch flag {
case publishAddress:
cmd.Flags().StringVar(&config.PublishAddress, publishAddress.String(), "https://api.obol.tech/v1", maybeRequired("The URL of the remote API."))
Expand Down Expand Up @@ -149,9 +148,8 @@
cmd.Flags().DurationVar(&config.PublishTimeout, publishTimeout.String(), 30*time.Second, "Timeout for publishing a signed exit to the publish-address API.")
case validatorIndex:
cmd.Flags().Uint64Var(&config.ValidatorIndex, validatorIndex.String(), 0, "Validator index of the validator to exit, the associated public key must be present in the cluster lock manifest. If --validator-public-key is also provided, validator existence won't be checked on the beacon chain.")
// TODO: enable after all functionalities for --all are ready
// case all:
// cmd.Flags().BoolVar(&config.All, all.String(), false, "Exit all currently active validators in the cluster.")
case all:
cmd.Flags().BoolVar(&config.All, all.String(), false, "Exit all currently active validators in the cluster.")

Check warning on line 152 in cmd/exit.go

View check run for this annotation

Codecov / codecov/patch

cmd/exit.go#L151-L152 

Added lines #L151 - L152 were not covered by tests
}

if f.required {
Expand Down
Loading