-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: update bls-eth-go-binary #3349
Conversation
Recent DKG issues may be due to an issue in bls-eth-go-binary, caused by an upstream bug in their dependencies. Update to v1.36.1 which solves the issue. Reference: herumi/bls-eth-go-binary#63
Quality Gate passedIssues Measures |
Looks like we will need to create a release-v1.1.2 branch, update app version there and then PR into that branch instead of main-v1.1? or is it fine to directly PR to main-v1.1? I am confused what we allow and what not :) |
If you look at the history of Github actions will take care of fixing the version string at compile time. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-v1.1 #3349 +/- ##
=============================================
- Coverage 57.74% 57.70% -0.04%
=============================================
Files 211 211
Lines 30398 30398
=============================================
- Hits 17552 17540 -12
- Misses 10965 10972 +7
- Partials 1881 1886 +5 ☔ View full report in Codecov by Sentry. |
Thank you for clarifying! |
Manually merging to kick the v1.1.2 tag down the line. |
Recent DKG issues may be due to an issue in bls-eth-go-binary, caused by an upstream bug in their dependencies.
Update to v1.36.1 which solves the issue.
Reference: herumi/bls-eth-go-binary#63
category: bug
ticket: none