Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: test command file output improvements #3384

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

KaloyanTanev
Copy link
Contributor

Couple of small improvements over the test command:

  • Swap TOML with JSON file on output
  • Change the file format to include all 5 categories, so commands like test all can successfully write all results to the file
  • Safe write to the file (using temp file)
  • Put the MEV create block tests under a --load-test flag, so we don't put external infra under excess in the default case

An some small fixes that have been missed:

  • Rename the testperformance file to testinfra
  • Add the beacon node simulations file directory for results as a flag

category: refactor
ticket: none

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 69.56522% with 21 lines in your changes missing coverage. Please review.

Project coverage is 57.35%. Comparing base (81563b9) to head (48be92d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/test.go 56.25% 15 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3384      +/-   ##
==========================================
+ Coverage   57.33%   57.35%   +0.01%     
==========================================
  Files         217      217              
  Lines       31915    31964      +49     
==========================================
+ Hits        18300    18332      +32     
- Misses      11727    11736       +9     
- Partials     1888     1896       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 15, 2024

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 15, 2024
@obol-bulldozer obol-bulldozer bot merged commit eba4d33 into main Nov 15, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/test-command-file-output-improvements branch November 15, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants