Skip to content

Conversation

pinebit
Copy link
Collaborator

@pinebit pinebit commented Sep 15, 2025

  • Added pedersen DKG algorithm using kyber library.
  • Added alpha edit recreate-private-keys command.
  • Added alpha edit add-operators command.
  • Added alpha edit remove-operators command.
  • Moved add-validators to the alpha edit section.
  • Ongoing code refactoring.

category: feature
ticket: #3672

Copilot

This comment was marked as outdated.

@ObolNetwork ObolNetwork deleted a comment from Copilot AI Sep 15, 2025
@pinebit pinebit requested a review from aadomn September 15, 2025 09:42
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 59.99044% with 837 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.84%. Comparing base (14a1e4e) to head (8a6a375).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
dkg/dkgpb/v1/pedersen.pb.go 0.00% 324 Missing ⚠️
dkg/pedersen/reshare.go 60.81% 67 Missing and 20 partials ⚠️
dkg/protocol.go 52.40% 56 Missing and 23 partials ⚠️
dkg/pedersen/board.go 64.25% 54 Missing and 20 partials ⚠️
dkg/pedersen/dkg.go 68.27% 32 Missing and 14 partials ⚠️
dkg/protocolsteps.go 65.00% 28 Missing and 14 partials ⚠️
cmd/edit_addoperators.go 60.20% 35 Missing and 4 partials ⚠️
cmd/edit_removeoperators.go 71.81% 28 Missing and 3 partials ⚠️
cmd/edit_recreateprivatekeys.go 66.15% 21 Missing and 1 partial ⚠️
dkg/pedersen/proto.go 85.71% 12 Missing and 6 partials ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3977      +/-   ##
==========================================
+ Coverage   53.55%   53.84%   +0.28%     
==========================================
  Files         224      242      +18     
  Lines       37348    39348    +2000     
==========================================
+ Hits        20000    21185    +1185     
- Misses      15226    15924     +698     
- Partials     2122     2239     +117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pinebit pinebit marked this pull request as ready for review September 16, 2025 03:36
@pinebit pinebit requested a review from Copilot September 22, 2025 12:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 57 out of 58 changed files in this pull request and generated 6 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ObolNetwork ObolNetwork deleted a comment from Copilot AI Sep 22, 2025
@ObolNetwork ObolNetwork deleted a comment from Copilot AI Sep 22, 2025
@pinebit pinebit force-pushed the pinebit/pedersen-dkg branch 3 times, most recently from ce5700c to fc80c3e Compare September 30, 2025 06:37
@pinebit pinebit requested a review from Copilot September 30, 2025 07:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 48 out of 49 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ObolNetwork ObolNetwork deleted a comment from Copilot AI Sep 30, 2025
@ObolNetwork ObolNetwork deleted a comment from Copilot AI Sep 30, 2025
@ObolNetwork ObolNetwork deleted a comment from Copilot AI Sep 30, 2025
@ObolNetwork ObolNetwork deleted a comment from Copilot AI Sep 30, 2025
@ObolNetwork ObolNetwork deleted a comment from Copilot AI Sep 30, 2025
Copy link
Contributor

@DiogoSantoss DiogoSantoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge work!

Copy link
Contributor

@aadomn aadomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor code comments I catched but most importantly two other remarks:

  1. I think the addoperators command should not update the threshold.
  2. Maybe reconsidering the way we derive nonce for the Pedersen DKG.

@pinebit pinebit force-pushed the pinebit/pedersen-dkg branch from f87a244 to 65a1be2 Compare October 13, 2025 11:39
@pinebit pinebit force-pushed the pinebit/pedersen-dkg branch 2 times, most recently from bb84edb to cf27d6c Compare October 16, 2025 11:05
@pinebit pinebit force-pushed the pinebit/pedersen-dkg branch from cf27d6c to 8a6a375 Compare October 20, 2025 07:42
Copy link

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 20, 2025
@obol-bulldozer obol-bulldozer bot merged commit 677c59a into main Oct 20, 2025
12 of 14 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/pedersen-dkg branch October 20, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants