-
Notifications
You must be signed in to change notification settings - Fork 124
*: pedersen dkg #3977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: pedersen dkg #3977
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3977 +/- ##
==========================================
+ Coverage 53.55% 53.84% +0.28%
==========================================
Files 224 242 +18
Lines 37348 39348 +2000
==========================================
+ Hits 20000 21185 +1185
- Misses 15226 15924 +698
- Partials 2122 2239 +117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 57 out of 58 changed files in this pull request and generated 6 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ce5700c to
fc80c3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 48 out of 49 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor code comments I catched but most importantly two other remarks:
- I think the
addoperatorscommand should not update the threshold. - Maybe reconsidering the way we derive nonce for the Pedersen DKG.
f87a244 to
65a1be2
Compare
bb84edb to
cf27d6c
Compare
cf27d6c to
8a6a375
Compare
|



pedersenDKG algorithm using kyber library.alpha edit recreate-private-keyscommand.alpha edit add-operatorscommand.alpha edit remove-operatorscommand.add-validatorsto thealpha editsection.category: feature
ticket: #3672