Skip to content

Conversation

KaloyanTanev
Copy link
Collaborator

@KaloyanTanev KaloyanTanev commented Oct 15, 2025

  1. charon deposit sign: sign partial deposit -> publish to the api
  2. charon deposit fetch: fetch deposits from the api -> aggregate signatures -> save full deposit locally

category: feature
ticket: #3992

@KaloyanTanev KaloyanTanev self-assigned this Oct 15, 2025
@KaloyanTanev KaloyanTanev marked this pull request as draft October 15, 2025 11:36
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 22.67081% with 249 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.50%. Comparing base (ffc9dcd) to head (e4685dc).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
app/obolapi/deposit.go 0.00% 101 Missing ⚠️
cmd/depositsign.go 39.06% 60 Missing and 18 partials ⚠️
cmd/depositfetch.go 33.33% 34 Missing and 8 partials ⚠️
cmd/deposit.go 0.00% 21 Missing ⚠️
cmd/cmd.go 0.00% 4 Missing ⚠️
app/obolapi/api.go 0.00% 2 Missing ⚠️
cmd/exit_delete.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4032      +/-   ##
==========================================
+ Coverage   53.49%   53.50%   +0.01%     
==========================================
  Files         224      246      +22     
  Lines       37353    39665    +2312     
==========================================
+ Hits        19981    21224    +1243     
- Misses      15249    16176     +927     
- Partials     2123     2265     +142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KaloyanTanev KaloyanTanev marked this pull request as ready for review October 17, 2025 14:56
@KaloyanTanev KaloyanTanev requested review from DiogoSantoss and pinebit and removed request for DiogoSantoss and pinebit October 17, 2025 14:56
@KaloyanTanev KaloyanTanev marked this pull request as draft October 17, 2025 14:59
@KaloyanTanev KaloyanTanev marked this pull request as ready for review October 20, 2025 08:44
Copy link
Collaborator

@pinebit pinebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the first pass.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
15.4% Duplication on New Code (required ≤ 15%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants