Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change up testnet framing, highlight beta #293

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Change up testnet framing, highlight beta #293

merged 1 commit into from
Dec 13, 2023

Conversation

OisinKyne
Copy link
Contributor

Summary

Based on feedback that our docs may lead you to believe we're on testnet

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for obol-docs ready!

Name Link
🔨 Latest commit b117080
🔍 Latest deploy log https://app.netlify.com/sites/obol-docs/deploys/6573968a985f8300084407b2
😎 Deploy Preview https://deploy-preview-293--obol-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

For more information on running charon in a UI friendly way through the DV Launchpad, take a look at our [Quickstart Guides](docs/int/quickstart/index.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment this but on line 14 do you also want to change it to beta/holesky?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's goerli all over the site right now. Moving it all to holesky is something we can do in the new year and its own PR rather than making multi-network language here.

@OisinKyne OisinKyne merged commit c520d71 into main Dec 13, 2023
7 checks passed
@OisinKyne OisinKyne deleted the oisin/testnet branch December 13, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants