adding CSM info to group quickstart #426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for obol-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
OisinKyne
reviewed
Oct 4, 2024
| in the following steps you need to: | ||
| <ul> | ||
| <li> | ||
| Set <code>num-validators=1</code>. (only 1 CSM Validator can be deployed per cluster via the launchpad). |
There was a problem hiding this comment.
This is the CLI section, not sure this is needed
Comment on lines
+203
to
+206
| Set <code>withdrawal address</code> to Lido’s Withdrawal Vault Address: 0xF0179dEC45a37423EAD4FaD5fCb136197872EAd9 per [Lido’s documentation](https://docs.lido.fi/deployed-contracts/holesky/). | ||
| </li> | ||
| <li> | ||
| Set the <code>fee recipient</code> to Lido’s Execution Layer Rewards Vault Address: 0xE73a3602b99f1f913e72F8bdcBC235e206794Ac8 per Lido’s [documentation](https://docs.lido.fi/deployed-contracts/holesky/). |
There was a problem hiding this comment.
I think showing holesky addresses here is a bad idea, I don't believe this guide is network specific anywhere other than this.
|
As discussed, will create a separate page in the "advanced guides" section |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the CSM docs document Oisin & Kody created:
https://docs.google.com/document/d/1b6FWC0uGX-nwxvVxgKgoSXR0jb3xn3Tz6Ki0CcuNgHI/edit
I think it’s best if we don’t add another docs category or page, or even another set of tabs, but rather just insert the CSM instructions as an “info” box in the appropriate places, since the deviation is really just the withdrawal address and fee recipient address.
In the Group Quickstart doc, I’ve added an “info” box in the appropriate place within the “launchpad” flow as well as in the “CLI” flow.