save

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@observertc/observer-js",
-  "version": "0.40.19",
+  "version": "0.40.20",
   "description": "Server Side NodeJS Library for processing ObserveRTC Samples",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

src/ObservedClient.ts

@@ -108,6 +108,7 @@ export class ObservedClient<AppData extends Record<string, unknown> = Record<str
 	public readonly mediaDevices: string[] = [];
 	public readonly codecs: string[] = [];
 	public readonly userMediaErrors: string[] = [];
+	public readonly issues: ClientIssue[] = [];
 
 	public readonly ωpendingCreatedTracksTimestamp = new Map<string, number>();
 	public readonly ωpendingCreatedPeerConnectionTimestamp = new Map<string, number>();
@@ -235,6 +236,7 @@ export class ObservedClient<AppData extends Record<string, unknown> = Record<str
 			logger.warn(`Error adding client issue: ${(err as Error)?.message}`);
 		}
 
+		this.issues.push(issue);
 		this.emit('issue', issue);
 	}
 
@@ -433,6 +435,7 @@ export class ObservedClient<AppData extends Record<string, unknown> = Record<str
 							attachments: callEvent.attachments ? JSON.parse(callEvent.attachments) : undefined,
 						};
 
+						this.issues.push(issue);
 						this.emit('issue', issue);
 					} catch (err) {
 						logger.warn(`Error parsing client issue: ${(err as Error)?.message}`);

src/monitors/CallSummaryMonitor.ts

@@ -1,5 +1,5 @@
 import { EventEmitter } from 'events';
-import { CallSummary, ClientIssue, ClientSummary } from './CallSummary';
+import { CallSummary, ClientSummary } from './CallSummary';
 import { ObservedCall } from '../ObservedCall';
 import { ObservedClient } from '../ObservedClient';
 import { ObservedOutboundTrack } from '../ObservedOutboundTrack';
@@ -93,12 +93,6 @@ export class CallSummaryMonitor extends EventEmitter {
 			clientSummary.usedTurn ||= usingTurn;
 		};
 
-		const onIssue = (issue: ClientIssue) => {
-			++callSummary.numberOfIssues;
-			clientSummary.issues.push(issue);
-
-		};
-
 		const onUserMediaError = (error: string) => {
 			if (!this.config.detectUserMediaIssues) return;
 
@@ -113,7 +107,6 @@ export class CallSummaryMonitor extends EventEmitter {
 
 		client.on('update', updateClient);
 		client.on('usingturn', onUsingTurn);
-		client.on('issue', onIssue);
 		client.on('usermediaerror', onUserMediaError);
 		client.on('newpeerconnection', onNewPeerConnection);
 		client.once('close', () => {
@@ -127,14 +120,15 @@ export class CallSummaryMonitor extends EventEmitter {
 			clientSummary.totalDataChannelBytesReceived = client.totalDataChannelBytesReceived;
 			clientSummary.durationInMs = now - client.created;
 			clientSummary.left = now;
-
+			clientSummary.issues.push(...client.issues);
+
 			client.off('update', updateClient);
 			client.off('usingturn', onUsingTurn);
-			client.off('issue', onIssue);
 			client.off('usermediaerror', onUserMediaError);
 			client.off('newpeerconnection', onNewPeerConnection);
 
 			callSummary.durationInMs += clientSummary.durationInMs;
+			callSummary.numberOfIssues += clientSummary.issues.length;
 		});
 	}