Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source generator warnings #444

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix source generator warnings #444

merged 1 commit into from
Jul 24, 2024

Conversation

Seb-stian
Copy link
Member

Fixed all compiler warnings for the Obsidian.SourceGenerators project. Behavior should stay (almost) the same. Some code is awkward, because source generators cannot target the newest dotnet with all features.

@Seb-stian Seb-stian requested a review from Tides July 23, 2024 23:41
@github-actions github-actions bot added the source-generation Relates to Obsidian.SourceGenerators label Jul 23, 2024
@Seb-stian Seb-stian added priority: low Nice to have code-style Relates to code formatting and conventions labels Jul 23, 2024
Copy link
Member

@Tides Tides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Naamloos Naamloos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my limited sgen knowledge I can not say much more than "LGTM!"

@Seb-stian Seb-stian merged commit acf46ac into master Jul 24, 2024
2 checks passed
@Seb-stian Seb-stian deleted the fix-generator-warnings branch July 24, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-style Relates to code formatting and conventions priority: low Nice to have source-generation Relates to Obsidian.SourceGenerators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants