update to v1.1.1

Octagon-simon · May 23, 2022 · 0698265 · 0698265
1 parent b262506
commit 0698265
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 13 deletions.
diff --git a/README.md b/README.md
@@ -1,4 +1,4 @@
-# octaValidate V1.1.0
+# octaValidate V1.1.1
 
 <img align="center" src="https://octagon-simon.github.io/octaValidate/img/ov-success.png" width="100px">
 
@@ -227,10 +227,11 @@ To define a callback, invoke this method and pass in your function as an argumen
 ```javascript
 //create new instance of the function
 let formVal  = new octaValidate('form_register');
-
+//success callback
 let successCB = function(){
     alert("No validation errors");
 }
+//error callback
 let errorCB = function(){
     alert(formVal.status()+" validation error(s)")
 }
@@ -267,18 +268,16 @@ let formVal = new octaValidate('form_register');
 - customRule(RULE_TITLE, REG_EXP, ERROR_TEXT): Invoke this method to define your custom validation rule.
 - moreCustomRules(RULES): Invoke this method to define more custom validation rules.
 - version(): Invoke this method to retrieve version info.
-- validateCallBack(success_callback, error_callback): Invoke this method, providing your success callback or error callback as arguments.
+- validateCallBack(success_callback, error_callback): Invoke this method, providing your success callback or error callback as arguments. The success callback will execute when there are no validation errors and the error callback will execute when there are validation errors
 
-The success callback will execute when there are no validation errors and the error callback will execute when there are validation errors
 
 ## READ THE ARTICLE
 
 [Read the article on Medium](https://blog.bitsrc.io/client-side-form-validation-using-octavalidate-javascript-b150f2d14e99)
 
 ## DEMO
 
-- Download **octaValidate** and import it to your project.
-- Open **[demo.html](https://octagon-simon.github.io/octaValidate/demo.html)** on a browser, then submit the form.
+- Open **[demo.html](https://octagon-simon.github.io/octaValidate/demo.html)** (also included in the folder) and submit the form.
 
 ## SCREENSHOTS
 

diff --git a/src/validate.js b/src/validate.js
@@ -1,7 +1,7 @@
 /**
- * OctaValidate main JS V1.1.0
+ * OctaValidate main JS V1.1.1
  * author: Simon Ugorji
- * Last Edit : 21st May 2022
+ * Last Edit : 23rd May 2022
  */
 (function(){
     //global Styling
@@ -402,12 +402,14 @@ function octaValidate(form_ID, userConfig){
             if(validate !== null ||
                     validateAttr !== null){
                 //loop through all form elements with an ID attached to it
-                let formInputs = document.querySelectorAll(`#${form_id} input[id], textarea[id]`);
+                let formInputs = document.querySelectorAll(`#${form_id} [octavalidate], [length], [maxlength], [minlength], [equalto]`);
                 formInputs.forEach(input => {
-                    //errors is unique to the input id
-                    let formInputId = input.id;
-                    /* strict mode */
-                    //check if strict mode is enabled
+                    //check if id exists within the element
+                    if(input.id !== ""){
+                        //errors is unique to the input id
+                        let formInputId = input.id;
+                        /* strict mode */
+                        //check if strict mode is enabled
                         if(config.strictMode === true){
                             /* always reset the vcounters */
                             nextValidation = continueValidation = 0;
@@ -984,6 +986,7 @@ function octaValidate(form_ID, userConfig){
                     }else{
                         nextValidation++;
                     }//end of if id exists
+                    }//end of check if id is provided
                 }); //end of foreach loop
                 }//end of checkif validations exist
                 if(errors === 0){