Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnet-install.ps1 script for new CDN urls #1053

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

rhysparry
Copy link
Contributor

@rhysparry rhysparry commented Jan 5, 2025

Background

The .NET install links recently changed. We maintain a modified copy of the dotnet-install.ps1 script in this repository to ensure TLS 1.2 is used when the script is run on older operating systems.

This change applies these changes to the current latest script.

Results

Script updated to reflect the upstream changes. Note: the upstream version includes the new domains, but still has some references to the old domains (dotnetcli.azureedge.net and dotnetbuilds.azureedge.net). There is an upstream issue tracking this: dotnet/install-scripts#559

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@rhysparry rhysparry marked this pull request as ready for review January 5, 2025 22:14
@rhysparry rhysparry requested a review from a team as a code owner January 5, 2025 22:14
@rhysparry
Copy link
Contributor Author

Is there an easy way to see the differences between the original script form the dotnet repo, and our modified version?

If you check out the branch locally you can run the following to compare this version with the currently published upstream.

diff --color=auto --strip-trailing-cr <(curl --location https://dot.net/v1/dotnet-install.ps1) dotnet-install.ps1

Copy link
Contributor

@gb-8 gb-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe considered out-of-scope, but the way we are enabling TLS 1.2 forces the disabling of TLS 1.3.

I think it would be better to bitwise AND with TLS 1.2 instead of straight assignment.

Copy link
Contributor

@gb-8 gb-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but with same question about not disabling TLS 1.3 as on the Halibut PR.

@rhysparry rhysparry merged commit f56fe16 into main Jan 6, 2025
51 of 52 checks passed
@rhysparry rhysparry deleted the sast/sync-dotnet-install-script branch January 6, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants