Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test tentacle client with recommended timeouts, like in Octopus #723

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Test tentacle client with recommended timeouts, like in Octopus #723

merged 1 commit into from
Dec 4, 2023

Conversation

LukeButters
Copy link
Contributor

@LukeButters LukeButters commented Dec 4, 2023 •
edited
Loading

Background

Test the tentacle client with recommended halibut timeouts, since we are about to use those in Octopus Server.

[[SI-65621]]

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@LukeButters LukeButters marked this pull request as ready for review December 4, 2023 23:23
@LukeButters LukeButters requested a review from a team as a code owner December 4, 2023 23:23
@LukeButters LukeButters changed the title Test tentacle client with recommended timeouts Test tentacle client with recommended timeouts, like in Octopus Dec 4, 2023
@LukeButters LukeButters merged commit e65ce9c into main Dec 4, 2023
2 checks passed
@LukeButters LukeButters deleted the sast/test-tentacle-client-with-lowered-timeouts branch December 4, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwoctopusdeploy nathanwoctopusdeploy nathanwoctopusdeploy approved these changes

@sburmanoctopus sburmanoctopus Awaiting requested review from sburmanoctopus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukeButters @nathanwoctopusdeploy