Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #2015

Closed
wants to merge 106 commits into from
Closed

Spelling #2015

wants to merge 106 commits into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Sep 29, 2023

Fixes misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/OctopusDeploy-docs/actions/runs/6352029753/attempts/1#summary-17254199293

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/OctopusDeploy-docs/actions/runs/6352031017/attempts/1#summary-17254201667

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Sep 29, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these changes imply changes to the programs.

They should probably be split out and the documented buggy programs fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-wizard-service-accunt-ad.png
+wizard-service-account-ad.png

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-kustomise-step.png
+kustomize-step.png

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-create-service-acount.png
+create-service-account.png

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-EditOnGithub.astro
+EditOnGitHub.astro

import EditOnGithub from '../components/EditOnGithub.astro';
import EditOnGitHub from '../components/EditOnGitHub.astro';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed above

Comma-seperated list of URLs that are trusted
Comma-separated list of URLs that are trusted
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably based on an actual program's buggy output, so please consider this as a bug report.

![Create service account](/docs/security/users-and-teams/images/create-service-acount.png)
![Create service account](/docs/security/users-and-teams/images/create-service-account.png)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed above

foreach ($environment in $action.Envrionments)
foreach ($environment in $action.Environments)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scary?

result.Link = apiURL.String() + project.Links["Web"] + "/deployments/process/stesp?actionId=" + action.ID
result.Link = apiURL.String() + project.Links["Web"] + "/deployments/process/steps?actionId=" + action.ID
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scary

# Establish a conneciton0
# Establish a connection
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@steve-fenton-octopus
Copy link
Contributor

Hello @jsoref

Thanks for the PR, we definitely want to fix many of these items. The PR is a bit too big to work with for the process of commenting on each change. There are one or two suggestions that aren't quite right in this context, so we created a PR to cover all the good suggestions.

#2016

Thanks,
Steve

@jsoref
Copy link
Contributor Author

jsoref commented Oct 2, 2023

cool.

fwiw, i've rebased the branch so https://github.com/OctopusDeploy/docs/compare/main...jsoref:spelling?expand=1 has most of the remainder, I think you'd probably want to take about half of them, most of the brand things in theory should be taken.

fwiw, this delta scares me, based on the .Count property, I suspect that the change is right:

            $hasEnvironmentScoping = $action.Environments.Count -gt 0
            if ($hasEnvironmentScoping -eq $true)
            {
-               foreach ($environment in $action.Environment)
+               foreach ($environment in $action.Environments)

I'm not going to make another PR for this repository for this purpose, so I'm just leaving the branch available and this comment as a note.

Thanks for the very prompt attention. I understand it was a huge PR to review. (I don't expect reviews anywhere near this fast and certainly not for anything of this size.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants