-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #2015
Spelling #2015
Conversation
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these changes imply changes to the programs.
They should probably be split out and the documented buggy programs fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-wizard-service-accunt-ad.png
+wizard-service-account-ad.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-kustomise-step.png
+kustomize-step.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-create-service-acount.png
+create-service-account.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-EditOnGithub.astro
+EditOnGitHub.astro
import EditOnGithub from '../components/EditOnGithub.astro'; | ||
import EditOnGitHub from '../components/EditOnGitHub.astro'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed above
Comma-seperated list of URLs that are trusted | ||
Comma-separated list of URLs that are trusted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably based on an actual program's buggy output, so please consider this as a bug report.
![Create service account](/docs/security/users-and-teams/images/create-service-acount.png) | ||
![Create service account](/docs/security/users-and-teams/images/create-service-account.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed above
foreach ($environment in $action.Envrionments) | ||
foreach ($environment in $action.Environments) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scary?
result.Link = apiURL.String() + project.Links["Web"] + "/deployments/process/stesp?actionId=" + action.ID | ||
result.Link = apiURL.String() + project.Links["Web"] + "/deployments/process/steps?actionId=" + action.ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scary
# Establish a conneciton0 | ||
# Establish a connection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
Hello @jsoref Thanks for the PR, we definitely want to fix many of these items. The PR is a bit too big to work with for the process of commenting on each change. There are one or two suggestions that aren't quite right in this context, so we created a PR to cover all the good suggestions. Thanks, |
cool. fwiw, i've rebased the branch so https://github.com/OctopusDeploy/docs/compare/main...jsoref:spelling?expand=1 has most of the remainder, I think you'd probably want to take about half of them, most of the brand things in theory should be taken. fwiw, this delta scares me, based on the $hasEnvironmentScoping = $action.Environments.Count -gt 0
if ($hasEnvironmentScoping -eq $true)
{
- foreach ($environment in $action.Environment)
+ foreach ($environment in $action.Environments) I'm not going to make another PR for this repository for this purpose, so I'm just leaving the branch available and this comment as a note. Thanks for the very prompt attention. I understand it was a huge PR to review. (I don't expect reviews anywhere near this fast and certainly not for anything of this size.) |
Fixes misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/OctopusDeploy-docs/actions/runs/6352029753/attempts/1#summary-17254199293
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/OctopusDeploy-docs/actions/runs/6352031017/attempts/1#summary-17254201667