Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doco for deploy a release cf step #2506

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Add doco for deploy a release cf step #2506

merged 1 commit into from
Sep 17, 2024

Conversation

mik-ky
Copy link
Contributor

@mik-ky mik-ky commented Sep 17, 2024

[sc-92084]

tothegills
tothegills approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@tothegills tothegills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor details to consider

src/pages/docs/packaging-applications/build-servers/codefresh-pipelines.md Outdated
VARIABLES:
- "Greeting:Hello"
USE_GUIDED_FAILURE: "false"
ENVIRONMENTS:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENVIRONMENTS after RELEASE_NUMBER would make it easier to compare with the above example

src/pages/docs/packaging-applications/build-servers/codefresh-pipelines.md Outdated
ENVIRONMENTS:
- "Development"
```
Additionally, you can provide optional arguments to specify guided failure mode or variables:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specify guided failure mode and variables ?

@mik-ky mik-ky merged commit 6c96969 into fnm/codefreshSteps Sep 17, 2024
3 of 4 checks passed
@mik-ky mik-ky deleted the deploy-release branch September 17, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tothegills tothegills tothegills approved these changes

@bec-callow-oct bec-callow-oct bec-callow-oct approved these changes

@steve-fenton-octopus steve-fenton-octopus Awaiting requested review from steve-fenton-octopus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mik-ky @tothegills @bec-callow-oct