Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment create amount from int64 to float64 #168

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Conversation

keikari
Copy link
Contributor

@keikari keikari commented Jan 28, 2025

Makes the amount in comment create to match the rest of the requests. (Settings and responses have amount in float64)

! NOTE !
Should be safe to merge. Think this will make dryRun min limit pass with any LBC tip, since frontend is still sending amount in satoshis. But since UI prevents sending of smaller tips, it should be fine as is.

@keikari keikari marked this pull request as ready for review January 28, 2025 08:28
keikari pushed a commit to OdyseeTeam/odysee-frontend that referenced this pull request Jan 28, 2025
@tzarebczan tzarebczan merged commit 807b06b into master Jan 28, 2025
2 checks passed
keikari added a commit to OdyseeTeam/odysee-frontend that referenced this pull request Jan 31, 2025
* Add USDC minTip/hyperchat in channel settings
Add USDC minTip/hyperchat in file page
Partly add USDC icon (used currently with fiat tips)
Align LBC icon better with text

* USDC -> USD (UI icons/text)

* Remove bit more USDC

* Separate the debounces for lbc/usdc settings updates

* Show warning when only one currency limit set + other fixes
  - Don't update the field while editing
  - Clearing a field sets value to 0

* Remove duplicate lines

* Fix hyperchat limit width issue on livestreams

* Change amount to match commentron change OdyseeTeam/commentron#168

* Forgot to removed this earlier

* Update setting warnings

* Minor clean (forgot to delete line)

---------

Co-authored-by: miko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants