Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #216

Closed
wants to merge 1 commit into from
Closed

Update README.md #216

wants to merge 1 commit into from

Conversation

Poussinou
Copy link

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

close #139

What is the current behavior?

Add two buttons to get the app on Google Play, and its FLOSS variant on F-Droid

@kekkyojin
Copy link
Collaborator

I see this kind of PR as marketing focused instead of development focused.

Regular people know where to download apps. Open-source kind of people already know where to search for a FLOSS variant of any app. There is no need to add the links here.

There are also privacy concerns about directing people to any Google owned domain, which they will track user who arrives to the Play Store from GitHub. Let’s not make so easy to that company to create user profiles.

On the FLOSS-side, although this code has been implemented focused on FDroid, it could be deployed to other stores, not just FDroid.

People arriving here are the ones who want to build the app from scratch, or at least they are able to read code. Where to find an APK is not their main worry.

Finally this PR is not closing issue 139, as directing user to FDroid store will not magically make app to be available there. And if it is already there, again this PR has not done the job.

A much better place to add these links would be on Odysee front-end -not the repository README but the UI itself.

@kekkyojin
Copy link
Collaborator

Also these links are misleading as apps installed from there are currently not built from this repository source code

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Release on F-Droid
2 participants