Skip to content

Commit

Permalink
Consistency changes
Browse files Browse the repository at this point in the history
  • Loading branch information
@tersmitten
tersmitten committed Jun 22, 2018
1 parent 9a3c99e commit 0154b9c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ None
* `postfix_relayhost` [default: `false` (no relay host)]: Hostname to relay all email to
* `postfix_relayhost_port` [default: 587]: Relay port (on `postfix_relayhost`, if set)
* `postfix_sasl_security_options` [default: `noanonymous`]: SMTP client SASL security options
* `postfix_sasl_mechanism_filter` [default: empty (no filter)]: SMTP client SASL authentication mechanism filter ([see](http://www.postfix.org/postconf.5.html#smtp_sasl_mechanism_filter))
* `postfix_sasl_mechanism_filter` [default: `''`]: SMTP client SASL authentication mechanism filter ([see](http://www.postfix.org/postconf.5.html#smtp_sasl_mechanism_filter))
* `postfix_relaytls` [default: `false`]: Use TLS when sending with a relay host
* `postfix_smtp_tls_cafile` [optional]: A file containing CA certificates of root CAs trusted to sign either remote SMTP server certificates or intermediate CA certificates (e.g. `/etc/ssl/certs/ca-certificates.crt`)
* `postfix_sasl_user` [default: `postmaster@{{ ansible_domain }}`]: SASL relay username
Expand Down
2 changes: 1 addition & 1 deletion defaults/main.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ postfix_sasl_auth_enable: true
postfix_sasl_user: "postmaster@{{ ansible_domain }}"
postfix_sasl_password: 'k8+haga4@#pR'
postfix_sasl_security_options: noanonymous
postfix_sasl_mechanism_filter: # empty
postfix_sasl_mechanism_filter: ''
postfix_inet_interfaces: all
postfix_inet_protocols: all
postfix_mydestination:
Expand Down

4 comments on commit 0154b9c

@dsteinkopf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When setting this so no value (not empty string) my intention was to prevent ansible from generating a postfix config line smtp_sasl_mechanism_filter =. Is there a way to make ansible to to generate this line at all?

@tersmitten
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make smtp_sasl_mechanism_filter optional (not define it in defaults/main.yml) and add an if in the template. But I think the way it works now is fine right?

Resulting in a line without a value

smtp_sasl_mechanism_filter =

@dsteinkopf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it I think works fine like this. Just a little optimization. I'd prefer not generating lines that do nothing (like this one without a value).
It's your decision...

@tersmitten
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep it like this (for now) :-)

Please sign in to comment.