Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add v1 publicActionsChildChain #139

Merged

Conversation

chrstph-dvx
Copy link
Contributor

SequencerInbox
Getters: #114
Setters: #117
Decorator: #119

RollupAdminLogic
Getters: #132
Settters: #133

ArbOwnerPublic
Getters #134
Setters #135

ArbGasInfo
Getters #136

UpgradeExecutor
Getters #137
Setters #138

@chrstph-dvx chrstph-dvx self-assigned this Jul 1, 2024
@chrstph-dvx chrstph-dvx changed the title Feat: Add v1 publicActionsChildChain feat: Add v1 publicActionsChildChain Jul 1, 2024
* transport: http(),
* }).extend(publicActionsChildChain())
*
* const isAChainOwner = await publicClientChildChain.isChainOwner({ address: zeroAddress })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know this is only an example but isAChainOwner deeply irritates me
can we change it to isChainOwner instead?

@chrstph-dvx chrstph-dvx force-pushed the add-publicActionsChildChain branch from 32775b3 to 9ecff00 Compare July 2, 2024 10:28
@chrstph-dvx chrstph-dvx force-pushed the add-upgradeexecutor-setters branch from 6ad97ef to ebc9d22 Compare July 2, 2024 10:29
@chrstph-dvx chrstph-dvx force-pushed the add-upgradeexecutor-setters branch from ebc9d22 to 6c8eef6 Compare July 9, 2024 16:27
@chrstph-dvx chrstph-dvx force-pushed the add-publicActionsChildChain branch from 9ecff00 to 3b85bbd Compare July 10, 2024 12:50
@chrstph-dvx chrstph-dvx force-pushed the add-upgradeexecutor-setters branch from 6c8eef6 to a8bab3b Compare July 10, 2024 13:08
@chrstph-dvx chrstph-dvx force-pushed the add-publicActionsChildChain branch 2 times, most recently from 3b85bbd to 3ca500f Compare July 10, 2024 13:47
@chrstph-dvx chrstph-dvx force-pushed the add-upgradeexecutor-setters branch 2 times, most recently from 56dfe8e to a826bac Compare July 10, 2024 15:54
@chrstph-dvx chrstph-dvx force-pushed the add-publicActionsChildChain branch from 3ca500f to 95231a3 Compare July 10, 2024 15:54
@chrstph-dvx chrstph-dvx force-pushed the add-publicActionsChildChain branch from 95231a3 to 3bb4a5f Compare July 10, 2024 16:48
@chrstph-dvx chrstph-dvx force-pushed the add-upgradeexecutor-setters branch from a826bac to 63f103e Compare July 10, 2024 16:48
Base automatically changed from add-upgradeexecutor-setters to create-parent-chain-public-decorator July 10, 2024 16:52
@chrstph-dvx chrstph-dvx merged commit 3bb4a5f into create-parent-chain-public-decorator Jul 10, 2024
3 checks passed
@chrstph-dvx chrstph-dvx deleted the add-publicActionsChildChain branch July 10, 2024 16:52
@chrstph-dvx chrstph-dvx restored the add-publicActionsChildChain branch July 10, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants