Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get contracts script (orbit verifier) #74

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

TucksonDev
Copy link
Contributor

This PR adds a new script to get all contracts of a chain (both rollup and tokenbridge)
This PR also updates some of the outputs to make them clearer

@TucksonDev TucksonDev requested a review from Jason-W123 April 9, 2024 12:20
@TucksonDev TucksonDev marked this pull request as draft April 9, 2024 12:21
@TucksonDev TucksonDev changed the base branch from main to feat-add-verification-scripts April 9, 2024 12:21
@TucksonDev TucksonDev changed the title [Verifier script] Add get contracts script feat: add get contracts script (orbit verifier) Apr 9, 2024
@TucksonDev TucksonDev marked this pull request as ready for review April 9, 2024 12:22
@TucksonDev TucksonDev marked this pull request as draft April 9, 2024 12:23
},
"devDependencies": {
"@types/node": "^20.9.0",
"typescript": "^5.2.2",
"@arbitrum/sdk": "^3.1.13",
"@arbitrum/orbit-sdk": "^0.9.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this dependency here now, since this script will likely move to a different orbit tooling repository. Description of the main branch/PR has been updated to cleanup this file and the yarn.lock file in case this script is finally kept in this repository.

// check if the rollups' arbos version is latest or not
if (index < latestWasmModuleRootIndex) {
/* if (index < latestWasmModuleRootIndex) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is commented out to handle different wasm module roots in a better way (I believe it shouldn't be a warning). There's a new task for this here.

@TucksonDev TucksonDev marked this pull request as ready for review April 9, 2024 12:31
@TucksonDev TucksonDev merged commit 6440408 into feat-add-verification-scripts Apr 15, 2024
5 of 7 checks passed
@TucksonDev TucksonDev deleted the add-get-contracts-script branch April 15, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants