Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ethbridge proxy admin addresses to networks config #263

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DZGoldman
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Mar 22, 2023
@TucksonDev
Copy link
Contributor

A couple of things:

  • If we change the interface, we need to add the proxyAdmin to the defaultLocalL2Network object in network.ts (I don't know what's the address though, or how to get it!).
  • We also need to return the address of the proxyAdmin when generating the local network, in scripts/testSetup.ts, in the getCustomNetworks() function. We might obtain it from the docker exec nitro_sequencer_1 cat /config/deployment.json command that is run when trying to get the local config.
  • Can you run the linter to add those missing commas and remove the warnings?

@spsjvc spsjvc marked this pull request as draft June 8, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants